Skip to content

Commit 776a239

Browse files
committed
Fix appimage docker file generation, esp. make kdesrc-build run
We need to skip gpgme and build a kgraphviewer branch that's compatible with KF5. Then we also modernize the kdesrc-build usage in general, allowing us to set the tag option on the frameworks module-set directly. That means we can get rid of the custom kf5-frameworks-build-include copy and use the upstream metadata definition directly
1 parent 2a1969d commit 776a239

File tree

3 files changed

+11
-47
lines changed

3 files changed

+11
-47
lines changed

scripts/appimage/Dockerfile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ ARG KDDockWidgets_VERSION=2.0
1212
ARG QCustomPlot_VERSION=2.1.1
1313
ARG rust_demangler_VERSION=0.1.23
1414
ARG d_demangler_VERSION=0.0.2
15+
ARG KGraphViewer_VERSION=v2.4.3a
1516

1617
USER root
1718

@@ -98,26 +99,24 @@ RUN cd /opt && mkdir dlang && cd dlang && \
9899
deactivate && cd /opt && rm -Rf dlang && mv /usr/bin/gpg{~,} && mv /usr/bin/gpg2{~,}
99100

100101
# kdesrc-build dependencies
101-
RUN yum install -y libcanberra-devel && \
102+
RUN yum install -y libcanberra-devel gpgme-devel && \
102103
cpan YAML::Syck JSON::XS YAML::XS
103104

104105
# kde frameworks
105106
RUN cd /opt && git clone https://invent.kde.org/sdk/kdesrc-build.git
106107
COPY kdesrc-buildrc /opt/kdesrc-build/
107-
COPY kf5-frameworks-build-include /opt/kdesrc-build/
108108
RUN ldconfig && \
109109
cd /opt/kdesrc-build && \
110-
sed -i -e "s/FULL_NPROC/$(nproc)/g" -e "s/HALF_NPROC/$(($(nproc)/2))/g" kdesrc-buildrc && \
111-
sed -i -e "s/%VERSION%/${KF5_VERSION}/g" kdesrc-buildrc && \
112-
sed -i -e "s/%VERSION%/${KF5_VERSION}/g" kf5-frameworks-build-include && \
110+
sed -i -e "s/FULL_NPROC/$(nproc)/g" \
111+
-e "s/HALF_NPROC/$(($(nproc)/2))/g" -e "s/%VERSION%/${KF5_VERSION}/g" kdesrc-buildrc && \
113112
./kdesrc-build --metadata-only && \
114113
# fix compile error in kwallet
115114
./kdesrc-build --include-dependencies qca && \
116-
./kdesrc-build --include-dependencies threadweaver kconfigwidgets kcoreaddons \
115+
./kdesrc-build --ignore-modules=gpgme --include-dependencies threadweaver kconfigwidgets kcoreaddons \
117116
kitemviews kitemmodels solid breeze-icons \
118117
kwindowsystem knotifications kiconthemes karchive syntax-highlighting kio kparts && \
119118
# without extra dependencies
120-
./kdesrc-build kgraphviewer && \
119+
./kdesrc-build --revision ${KGraphViewer_VERSION} --no-include-dependencies kgraphviewer && \
121120
cd /opt && rm -Rf kdesrc-build kde && ldconfig
122121

123122
# kddockwidgets

scripts/appimage/kdesrc-buildrc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,16 @@ end global
3838
# suit, and when you update kdesrc-build you will automatically pick up the
3939
# needed changes.
4040

41-
# NOTE: You MUST change the path below to include the actual path to your
42-
# kdesrc-build installation.
43-
include /opt/kdesrc-build/kf5-qt5-build-include
41+
include ${module-definitions-dir}/kf5-qt5.ksb
4442

4543
# If you wish to maintain the module list yourself that is possible, simply
4644
# look at the files pointed to above and use the "module-set" declarations that
4745
# they use, with your own changes.
4846

47+
options frameworks
48+
tag %VERSION%
49+
end options
50+
4951
# It is possible to change the options for modules loaded from the file
5052
# included above (since it's not possible to add a module that's already been
5153
# included), e.g.

scripts/appimage/kf5-frameworks-build-include

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)