fix: Escape HTML elements in disassembly view

bobsayshilol · milianw · commit 9d2767d148ab · 2026-03-10T21:47:17.000+01:00
Without this any disassembly comments are hidden. This also matches the
lines that don't have any captured samples.
diff --git a/src/models/disassemblymodel.cpp b/src/models/disassemblymodel.cpp
@@ -137,7 +137,7 @@ QVariant DisassemblyModel::data(const QModelIndex& index, int role) const
 
             if (role == Qt::ToolTipRole) {
                 auto tooltip = tr("addr: <tt>%1</tt><br/>assembly: <tt>%2</tt><br/>hexdump: <tt>%3</tt>")
-                                   .arg(QString::number(data.addr, 16), line, data.hexdump);
+                                   .arg(QString::number(data.addr, 16), line.toHtmlEscaped(), data.hexdump);
                 return Util::formatTooltip(tooltip, locationCost, m_results.selfCosts);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ QVariant DisassemblyModel::data(const QModelIndex& index, int role) const`
`137`	`137`
`138`	`138`	`if (role == Qt::ToolTipRole) {`
`139`	`139`	`auto tooltip = tr("addr: <tt>%1</tt><br/>assembly: <tt>%2</tt><br/>hexdump: <tt>%3</tt>")`
`140`		`- .arg(QString::number(data.addr, 16), line, data.hexdump);`
	`140`	`+ .arg(QString::number(data.addr, 16), line.toHtmlEscaped(), data.hexdump);`
`141`	`141`	`return Util::formatTooltip(tooltip, locationCost, m_results.selfCosts);`
`142`	`142`	`}`
`143`	`143`