Open
Conversation
…ра подъезда. Не совсем понял, почему этот способ является плохим.
Author
|
Что-то не так кодом? |
KateKhodko
requested changes
Dec 26, 2024
| // Константы | ||
| final int FLAT_AMOUNT_ON_ONE_FLOOR = 4; | ||
| final int FLAT_AMOUNT_ON_ONE_HOUSE = floorAmount * entranceAmount * FLAT_AMOUNT_ON_ONE_FLOOR; | ||
| final int FLAT_AMOUNT_ON_ONE_ENTRANCE = floorAmount * FLAT_AMOUNT_ON_ONE_FLOOR; |
Collaborator
There was a problem hiding this comment.
FLAT_AMOUNT_ON_ONE_HOUSE и FLAT_AMOUNT_ON_ONE_ENTRANCE лучше сделать локальными переменными
|
|
||
| return null; // Заглушка. При реализации - удалить | ||
| // Константы | ||
| final int FLAT_AMOUNT_ON_ONE_FLOOR = 4; |
Author
There was a problem hiding this comment.
Возможно, что-то неправильно понял, но добавить на дает
|
|
||
| // Проверка на входные данные | ||
| if (flatNumber > FLAT_AMOUNT_ON_ONE_HOUSE) { | ||
| return "Takoi kvartiry ne seschestvuet."; |
Collaborator
There was a problem hiding this comment.
весь текст написать как в примере, на русском, иначе не пройдут тесты
Author
There was a problem hiding this comment.
Исправил весь текст на кириллицу
| return flatNumber + " kv - " + entranceNumber + " pod_ezd, " + floorNumber + " etazh, " + flatLocationOnAFloor; | ||
| } | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
В конце файла по правилам оформления нужно оставлять пустую строку)
| int flatNumberEquivalent = flatNumber; | ||
| int entranceNumber = 1; | ||
|
|
||
| // Если квартира расположена не в первом подъезде |
Collaborator
There was a problem hiding this comment.
Необязательно оставлять так много комментариев, хороший код будет понятным и без них)
Комменты оставляем только в самом крайнем случае в местах с сложной логикой
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.