Code Check und Docker PHP-8

Author: kimbtech

.phan/config.php

@@ -0,0 +1,34 @@
+<?php
+/*
+	Run check via Docker-Installes Phan:
+
+	# function defined in shell
+	phan() {
+		docker run -v $PWD:/mnt/src --rm -u "1000:1000" phanphp/phan:latest $@; return $?;
+	} 
+
+	# start in document root of project
+	$ phan -o report.txt 
+*/
+return [
+	'target_php_version' => '8.0',
+	'directory_list' => [
+		'imexport',
+		'php',
+		'start'
+	],
+	'backward_compatibility_checks' => true,
+	'plugins' => [
+		'AlwaysReturnPlugin',
+		'DollarDollarPlugin',
+		'DuplicateArrayKeyPlugin',
+		'DuplicateExpressionPlugin',
+		'PregRegexCheckerPlugin',
+		'PrintfCheckerPlugin',
+		'SleepCheckerPlugin',
+		'UnreachableCodePlugin',
+		'UseReturnValuePlugin',
+		'EmptyStatementListPlugin',
+		'LoopVariableReusePlugin',
+	]
+];

Dockerfile

@@ -1,4 +1,4 @@
-FROM kimbtechnologies/php_nginx:latest 
+FROM kimbtechnologies/php_nginx:8-latest 
 
 # enable get_browser() in PHP
 RUN mkdir /start/ \

VERSION

@@ -1,4 +1,4 @@
 latest
-0.5.5
+0.5.6
 0.5
 0

php/core/Calendar.php

@@ -15,7 +15,9 @@ class Calendar {
 
 	private const CAL_EOL = "\r\n";
 
-	public function __construct( Login $login ) {
+	private Login $login;
+
+	public function __construct(Login $login) {
 		$this->login = $login;
 	}
 

php/core/Config.php

@@ -39,7 +39,7 @@ public static function getBaseUrl() : string {
 	}
 
 	public static function getImprintData() : ?array {
-		if(empty($_ENV['CONF_IMPRESSUMURL']) || empty($_ENV['CONF_IMPRESSUMURL'])){
+		if(empty($_ENV['CONF_IMPRESSUMURL']) || empty($_ENV['CONF_IMPRESSUMNAME'])){
 			return null;
 		}
 		return array(

php/core/DataAccess.php

@@ -21,7 +21,7 @@ class DataAccess {
 	private array $cmd = array();
 	private array $cmdSemantical = array();
 
-	private array $allShares = array();
+	private array $shares = array();
 
 	public function __construct( Login $login, Share $share ) {
 		$this->login = $login;

php/core/JSONReader.php

@@ -278,7 +278,7 @@ private function setValueHelper( $index, $value, $data ){
 			//ersten Index raus
 			$i0 = array_shift( $index );
 			//machen (Rekursion)
-			$data[$i0] = $this->setValueHelper( $index, $value, $data[$i0] );
+			$data[$i0] = $this->setValueHelper( $index, $value, $data[$i0] ); // @phan-suppress-current-line PhanTypeArraySuspiciousNullable
 		}
 		//ganzes Array zurueck
 		return $data;