Minor code improvements

Author: RatinCN

Source/Include/KNSoft/NDK/Package/RandGen.inl

@@ -14,9 +14,7 @@
 
 #include "../NDK.h"
 
-/*
- * Generate software random numbers by calling RtlRandomEx [0..MAXLONG-1], use the low 31 bits only
- */
+/* Generate software random numbers by calling RtlRandomEx [0..MAXLONG-1], use the low 31 bits only */
 
 static ULONG g_ulRandSeed = 0;
 
@@ -52,6 +50,7 @@ Rand_SW16(void)
 #if (defined(_M_X64) && !defined(_M_ARM64EC)) || defined(_M_IX86)
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW32(
     _Out_ unsigned int* Random)
@@ -71,6 +70,7 @@ Rand_HW32(
 }
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW64(
     _Out_ unsigned __int64* Random)
@@ -97,6 +97,7 @@ Rand_HW64(
 }
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW16(
     _Out_ unsigned short* Random)
@@ -119,6 +120,7 @@ Rand_HW16(
 #else
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW32(
     _Out_ unsigned int* Random)
@@ -128,6 +130,7 @@ Rand_HW32(
 }
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW64(
     _Out_ unsigned __int64* Random)
@@ -137,6 +140,7 @@ Rand_HW64(
 }
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HW16(
     _Out_ unsigned short* Random)
@@ -160,6 +164,7 @@ Rand_SWSizeT(VOID)
 }
 
 __forceinline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HWSizeT(
     _Out_ SIZE_T* Random)
@@ -232,6 +237,7 @@ Rand_SWBuffer(
 }
 
 __inline
+_Success_(return != FALSE)
 LOGICAL
 Rand_HWBuffer(
     _Out_writes_bytes_(RandomBufferLength) void* RandomBuffer,

Source/Include/KNSoft/NDK/Win32/API/Kernel32.inl

@@ -204,7 +204,7 @@ _Inline_GetModuleHandleW(
         return (HMODULE)NtCurrentPeb()->ImageBaseAddress;
     }
 
-    RtlInitUnicodeString(&DllName, lpModuleName);
+    _Inline_RtlInitUnicodeString(&DllName, lpModuleName);
     Status = LdrGetDllHandle(NULL, NULL, &DllName, &DllHandle);
     if (NT_SUCCESS(Status))
     {
@@ -247,7 +247,7 @@ _Inline_GetModuleHandleExW(
 
     if (lpModuleName == NULL)
     {
-        *phModule = NtCurrentPeb()->ImageBaseAddress;
+        *phModule = (HMODULE)NtCurrentPeb()->ImageBaseAddress;
         return TRUE;
     }
     if (dwFlags & GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS)
@@ -259,7 +259,7 @@ _Inline_GetModuleHandleExW(
         }
     } else
     {
-        RtlInitUnicodeString(&DllName, lpModuleName);
+        _Inline_RtlInitUnicodeString(&DllName, lpModuleName);
         Status = LdrGetDllHandle(NULL, NULL, &DllName, &DllHandle);
         if (!NT_SUCCESS(Status))
         {
@@ -275,7 +275,7 @@ _Inline_GetModuleHandleExW(
         }
     }
 
-    *phModule = DllHandle;
+    *phModule = (HMODULE)DllHandle;
     return TRUE;
 
 _Fail:
@@ -310,7 +310,7 @@ _Inline_GetModuleFileNameW(
         }
     } else
     {
-        PRTL_PERTHREAD_CURDIR PerThreadCurdir = NtReadTeb(NtTib.SubSystemTib);
+        PRTL_PERTHREAD_CURDIR PerThreadCurdir = (PRTL_PERTHREAD_CURDIR)NtReadTeb(NtTib.SubSystemTib);
         if (PerThreadCurdir != NULL && PerThreadCurdir->ImageName != NULL)
         {
             ImageName = PerThreadCurdir->ImageName;
@@ -320,7 +320,9 @@ _Inline_GetModuleFileNameW(
     }
 
     PLDR_DATA_TABLE_ENTRY HeadEntry, Entry;
-    HeadEntry = CONTAINING_RECORD(NtCurrentPeb()->Ldr->InLoadOrderModuleList.Flink, LDR_DATA_TABLE_ENTRY, InLoadOrderLinks);
+    HeadEntry = CONTAINING_RECORD(NtCurrentPeb()->Ldr->InLoadOrderModuleList.Flink,
+                                  LDR_DATA_TABLE_ENTRY,
+                                  InLoadOrderLinks);
     Entry = HeadEntry;
     LdrLockLoaderLock(LDR_LOCK_LOADER_LOCK_FLAG_RAISE_ON_ERRORS, NULL, &Cookie);
     LoaderLocked = TRUE;
@@ -1300,7 +1302,6 @@ _Inline_InterlockedPushListSListEx(
         RtlInterlockedPushListSList
 #endif
         (ListHead, List, ListEnd, Count);
-
 }
 
 __inline