Skip to content

Commit 22acfd3

Browse files
committed
Issue #22. Fix code style and comments in tests
1 parent b93bf65 commit 22acfd3

File tree

6 files changed

+11
-15
lines changed

6 files changed

+11
-15
lines changed

src/kpi_rover_ecu/include/IClient.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ class IClient {
2222
IClient& operator=(IClient&&) = delete;
2323
};
2424

25-
#endif
25+
#endif

src/kpi_rover_ecu/include/TCPTransport.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ class TCPTransport : public ITransport {
3030
int Init() override;
3131
void Destroy() override;
3232

33-
std::string GetSourceIp();
34-
int GetSourcePort();
33+
std::string GetClientIp();
34+
int GetClientPort();
3535

3636
private:
3737
int sockfd_, client_sockfd_;

src/kpi_rover_ecu/src/KPIRoverECU.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ void KPIRoverECU::IMUThreadFucntion(IMUController *workClass) {
4444
int destination_port = 0;
4545

4646
while (destination_address.empty()) {
47-
destination_address = tcp_transport_->GetSourceIp();
48-
destination_port = tcp_transport_->GetSourcePort();
47+
destination_address = tcp_transport_->GetClientIp();
48+
destination_port = tcp_transport_->GetClientPort();
4949
}
5050

5151
udp_client_->Init(destination_address, destination_port);

src/kpi_rover_ecu/src/TCPTransport.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,9 @@ bool TCPTransport::Send(const std::vector<std::uint8_t> &data) {
111111

112112
bool TCPTransport::Receive(std::vector<std::uint8_t> &data) { return messageQueue_.Pop(data, kTimeoutMs); }
113113

114-
std::string TCPTransport::GetSourceIp() { return std::string(source_address_); }
114+
std::string TCPTransport::GetClientIp() { return std::string(source_address_); }
115115

116-
int TCPTransport::GetSourcePort() { return source_port_; }
116+
int TCPTransport::GetClientPort() { return source_port_; }
117117

118118
void TCPTransport::Destroy() {
119119
running_ = false;

src/kpi_rover_ecu/tests/mocks/librobotcontrol/src/imu.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,16 @@ int rc_mpu_initialize_dmp(rc_mpu_data_t* data, rc_mpu_config_t config) {
2525

2626
int rc_mpu_power_off(void) {
2727
GetMockRCMPU().power_off();
28-
return 0; // Возвращаем успешный код
28+
return 0;
2929
}
3030

3131
int rc_mpu_read_accel(rc_mpu_data_t* data) { return GetMockRCMPU().read_accel(data); }
3232

3333
int rc_mpu_read_gyro(rc_mpu_data_t* data) { return GetMockRCMPU().read_gyro(data); }
3434

35-
// Реализация rc_mpu_default_config
3635
rc_mpu_config_t rc_mpu_default_config(void) {
3736
rc_mpu_config_t config = {};
38-
config.i2c_bus = 2; // Настройка I2C шины
37+
config.i2c_bus = 2;
3938
config.gpio_interrupt_pin_chip = 3;
4039
config.gpio_interrupt_pin = 21;
4140
config.dmp_sample_rate = 100;

src/kpi_rover_ecu/tests/test_imu_controller.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,13 @@ TEST_F(IMUControllerTest, GetDataWhenDisabled) {
5555
TEST_F(IMUControllerTest, GetDataWhenEnabled) {
5656
imu_controller.SetEnable();
5757

58-
// Настройка моков для чтения данных акселерометра, гироскопа, кватернионов
5958
EXPECT_CALL(GetMockRCMPU(), read_accel(::testing::_)).WillOnce(::testing::Return(0));
6059
EXPECT_CALL(GetMockRCMPU(), read_gyro(::testing::_)).WillOnce(::testing::Return(0));
6160

62-
// Получение данных
6361
std::vector<float> data = imu_controller.GetData();
6462

65-
// Проверка того, что данные возвращены
66-
ASSERT_EQ(data.size(), 10); // Убедимся, что размер данных соответствует ожидаемому
67-
SUCCEED(); // Успешное завершение теста
63+
ASSERT_EQ(data.size(), 10);
64+
SUCCEED();
6865
}
6966

7067
// Test IMUController::Stop

0 commit comments

Comments
 (0)