Issue #22: Fixed code style

Author: taketook34

src/kpi_rover_ecu/include/IMUController.h

@@ -4,6 +4,7 @@
 #include <rc/mpu.h>
 
 #include <atomic>
+#include <cstddef>
 #include <cstdint>
 #include <vector>
 

src/kpi_rover_ecu/include/TCPTransport.h

@@ -2,6 +2,7 @@
 #define TCPTRANSPORT_H
 
 #include <arpa/inet.h>
+
 #include <atomic>
 #include <cstdint>
 #include <cstring>

src/kpi_rover_ecu/src/KPIRoverECU.cpp

@@ -5,8 +5,8 @@
 
 #include <csignal>
 #include <cstdint>
-#include <cstring>
 #include <iostream>
+#include <string>
 #include <vector>
 
 #include "TCPTransport.h"
@@ -40,7 +40,7 @@ bool KPIRoverECU::Start() {
 void KPIRoverECU::IMUThreadFucntion(IMUController *workClass) {
     uint16_t packet_number = 0;
 
-    std::string destination_address = "";
+    std::string destination_address;
     int destination_port = 0;
 
     while (destination_address.empty()) {
@@ -58,7 +58,6 @@ void KPIRoverECU::IMUThreadFucntion(IMUController *workClass) {
             }
             packet_number += 1;
 
-            //std::cout << "Client connected " << tcp_transport_->GetSourceIp() << ":" << tcp_transport_->GetSourcePort() << '!' << '\n';
             std::vector<uint8_t> send_val;
             send_val.push_back(workClass->GetId());
 

src/kpi_rover_ecu/src/TCPTransport.cpp

@@ -8,8 +8,8 @@
 
 #include <cstdint>
 #include <cstdio>
-#include <cstring>
 #include <iostream>
+#include <string>
 #include <vector>
 
 constexpr std::size_t kBufferSize = 1024;
@@ -75,16 +75,15 @@ int TCPTransport::Init() {
 
 void TCPTransport::Start() {
     acceptThread_ = std::thread([this]() {
-        struct sockaddr_in client_addr;
+        struct sockaddr_in client_addr {};
         socklen_t client_add_size = sizeof(client_addr);
 
         while (running_) {
             std::cout << "Waiting for connection..." << '\n';
-            client_sockfd_ = accept(sockfd_, reinterpret_cast<sockaddr*>(&client_addr), &client_add_size);
+            client_sockfd_ = accept(sockfd_, reinterpret_cast<sockaddr *>(&client_addr), &client_add_size);
             if (client_sockfd_ >= 0) {
                 inet_ntop(AF_INET, &client_addr.sin_addr, source_address_, INET_ADDRSTRLEN);
                 source_port_ = static_cast<int>(ntohs(client_addr.sin_port));
-                //std::cout << "Client connected " << source_address_ << ":" << ntohs(client_addr.sin_port) << '\n';
                 while (true) {  // Use true instead of 1
                     std::uint8_t buffer[kBufferSize];
                     const ssize_t kBytesReceived = recv(client_sockfd_, buffer, sizeof(buffer), 0);

src/kpi_rover_ecu/src/UDPClient.cpp

@@ -13,8 +13,7 @@
 #include <string>
 #include <vector>
 
-UDPClient::UDPClient()
-    : sockfd_(-1), server_portnum_(0), server_address_({0}) {}
+UDPClient::UDPClient() : sockfd_(-1), server_portnum_(0), server_address_{} {}
 
 int UDPClient::Init(std::string ip_address, int port) {
     std::strncpy(server_address_, ip_address.c_str(), INET_ADDRSTRLEN);
@@ -54,5 +53,4 @@ UDPClient::~UDPClient() {
     shutdown(sockfd_, SHUT_WR);
 
     close(sockfd_);
-    delete[] server_address_;
 }

src/kpi_rover_ecu/tests/test_imu_controller.cpp

@@ -45,15 +45,6 @@ TEST_F(IMUControllerTest, InitFailure) {
     ASSERT_EQ(result, -1);
 }
 
-// Test IMUController::SetEnable and GetEnable
-TEST_F(IMUControllerTest, EnableDisable) {
-    imu_controller.SetEnable();
-    ASSERT_TRUE(imu_controller.GetEnable());
-
-    imu_controller.SetDisable();
-    ASSERT_FALSE(imu_controller.GetEnable());
-}
-
 // Test IMUController::GetData
 TEST_F(IMUControllerTest, GetDataWhenDisabled) {
     imu_controller.SetDisable();