Merge pull request #139 from KQMATH/update-ci-workflow

Update CI workflow and fix various problems

Author: sebastsg

.github/workflows/main.yml

@@ -4,11 +4,11 @@ on: [push, pull_request]
 
 jobs:
   test:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     services:
       postgres:
-        image: postgres:13
+        image: postgres:16
         env:
           POSTGRES_USER: 'postgres'
           POSTGRES_HOST_AUTH_METHOD: 'trust'
@@ -20,23 +20,30 @@ jobs:
         image: mariadb:10
         env:
           MYSQL_USER: 'root'
-          MYSQL_ALLOW_EMPTY_PASSWORD: "true"
-          MYSQL_CHARACTER_SET_SERVER: "utf8mb4"
-          MYSQL_COLLATION_SERVER: "utf8mb4_unicode_ci"
+          MYSQL_ALLOW_EMPTY_PASSWORD: 'true'
+          MYSQL_CHARACTER_SET_SERVER: 'utf8mb4'
+          MYSQL_COLLATION_SERVER: 'utf8mb4_unicode_ci'
         ports:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval 10s --health-timeout 5s --health-retries 3
 
     strategy:
       fail-fast: false
       matrix:
-        php: ['8.0']
-        moodle-branch: ['MOODLE_403_STABLE']
-        database: [pgsql, mariadb]
+        include:
+          - php: '8.2'
+            moodle-branch: 'MOODLE_405_STABLE'
+            database: 'pgsql'
+          - php: '8.3'
+            moodle-branch: 'MOODLE_500_STABLE'
+            database: 'pgsql'
+          - php: '8.3'
+            moodle-branch: 'MOODLE_500_STABLE'
+            database: 'mariadb'
 
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           path: plugin
 
@@ -66,19 +73,14 @@ jobs:
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phplint
 
-      - name: PHP Copy/Paste Detector
-        continue-on-error: true # This step will show errors but will not fail
-        if: ${{ !cancelled() }}
-        run: moodle-plugin-ci phpcpd
-
       - name: PHP Mess Detector
         continue-on-error: true # This step will show errors but will not fail
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phpmd
 
       - name: Moodle Code Checker
         if: ${{ !cancelled() }}
-        run: moodle-plugin-ci phpcs --max-warnings 0
+        run: moodle-plugin-ci codechecker --max-warnings 0
 
       - name: Moodle PHPDoc Checker
         if: ${{ !cancelled() }}

.github/workflows/moodle-ci.yml

@@ -94,6 +94,7 @@ function show_all_jump_questions(jazzquiz $jazzquiz): array {
  * Get the form for the current question.
  *
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function get_question_form(jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -110,7 +111,7 @@ function get_question_form(jazzquiz_session $session, jazzquiz $jazzquiz): array
         /** @var output\renderer $renderer */
         $renderer = $jazzquiz->renderer;
         $isinstructor = $jazzquiz->is_instructor();
-        list($html, $js, $css) = $renderer->render_question_form($slot, $session->myattempt, $jazzquiz, $isinstructor);
+        [$html, $js, $css] = $renderer->render_question_form($slot, $session->myattempt, $jazzquiz, $isinstructor);
         $isalreadysubmitted = false;
     }
     $qtype = $session->get_question_type_by_slot($slot);
@@ -129,6 +130,7 @@ function get_question_form(jazzquiz_session $session, jazzquiz $jazzquiz): array
  * Start a new question.
  *
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function start_question(jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -210,6 +212,7 @@ function start_quiz(jazzquiz_session $session): array {
  * Submit a response for the current question.
  *
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function save_question(jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -298,6 +301,7 @@ function end_question(jazzquiz_session $session): array {
  * Get the correct answer for the current question.
  *
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function get_right_response(jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -405,6 +409,7 @@ function stack_to_latex(): array {
  *
  * @param string $action
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function handle_instructor_request(string $action, jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -432,6 +437,7 @@ function handle_instructor_request(string $action, jazzquiz_session $session, ja
  *
  * @param string $action
  * @param jazzquiz_session $session
+ * @param jazzquiz $jazzquiz
  * @return array
  */
 function handle_student_request(string $action, jazzquiz_session $session, jazzquiz $jazzquiz): array {
@@ -451,7 +457,6 @@ function handle_student_request(string $action, jazzquiz_session $session, jazzq
 function jazzquiz_ajax(): array {
     $action = required_param('action', PARAM_ALPHANUMEXT);
 
-    // TODO: Better solution if more non-session actions are added.
     if ($action === 'stack') {
         return stack_to_latex();
     }