Don't access test instance dir without copying

Author: HebaruSan

Tests/Core/GameInstanceManager.cs

@@ -362,6 +362,7 @@ public void FindAndRegisterDefaultInstances_WithMockedSteam_FindsInstances()
         {
             // Arrange
             using (var config = new FakeConfiguration(new List<Tuple<string, string, string>>(), null, null))
+            using (var nonSteamGameDir = TemporaryDirectory.CopiedFromDir(TestData.good_ksp_dir()))
             using (var dir = new TemporarySteamDirectory(
                                  new (string acfFileName, int appId, string appName)[]
                                  {
@@ -375,7 +376,7 @@ public void FindAndRegisterDefaultInstances_WithMockedSteam_FindsInstances()
                                  new (string name, string absPath)[]
                                  {
                                      (name:    "Test Instance",
-                                      absPath: Path.GetFullPath(TestData.good_ksp_dir())),
+                                      absPath: nonSteamGameDir),
                                  }))
             {
                 var steamLib = new SteamLibrary(dir);

Tests/Core/IO/SteamLibraryTests.cs

@@ -16,6 +16,7 @@ public sealed class SteamLibraryTests
         public void Constructor_WithValidLibrary_Works()
         {
             // Arrange
+            using (var nonSteamGameDir = TemporaryDirectory.CopiedFromDir(TestData.good_ksp_dir()))
             using (var dir = new TemporarySteamDirectory(
                                  new (string acfFileName, int appId, string appName)[]
                                  {
@@ -29,7 +30,7 @@ public void Constructor_WithValidLibrary_Works()
                                  new (string name, string absPath)[]
                                  {
                                      (name:    "Test Instance",
-                                      absPath: Path.GetFullPath(TestData.good_ksp_dir())),
+                                      absPath: nonSteamGameDir),
                                  }))
             {
                 // Act
@@ -50,6 +51,7 @@ public void Constructor_WithValidLibrary_Works()
         public void Constructor_WithCorruptedLibrary_Works()
         {
             // Arrange
+            using (var nonSteamGameDir = TemporaryDirectory.CopiedFromDir(TestData.good_ksp_dir()))
             using (var dir = new TemporarySteamDirectory(
                                  new (string acfFileName, int appId, string appName)[]
                                  {
@@ -63,7 +65,7 @@ public void Constructor_WithCorruptedLibrary_Works()
                                  new (string name, string absPath)[]
                                  {
                                      (name:    "Test Instance",
-                                      absPath: Path.GetFullPath(TestData.good_ksp_dir())),
+                                      absPath: nonSteamGameDir),
                                      (name:    "Empty StartDir",
                                       absPath: ""),
                                  }))

Tests/Data/TemporaryDirectory.cs

@@ -1,6 +1,8 @@
 using System;
 using System.IO;
 
+using CKAN;
+
 namespace Tests.Data
 {
     public class TemporaryDirectory : IDisposable
@@ -21,6 +23,14 @@ public TemporaryDirectory()
         {
         }
 
+        public static TemporaryDirectory CopiedFromDir(string fromPath)
+        {
+            var dir = new TemporaryDirectory();
+            Utilities.CopyDirectory(fromPath, dir,
+                                    Array.Empty<string>(), Array.Empty<string>());
+            return dir;
+        }
+
         public void Dispose()
         {
             Directory.Delete(true);