[Bug]: Already contains module: JNSQ

[DonnieDiggs]

Is there an existing issue for this?

• I have checked the existing issues for an existing issue. I even actually looked at the ones that are pinned to the top!

Operating System

Windows 10 Home

CKAN Version

v1.36.2.25356

Games

KSP 1

Game Version

1.12.5.3190

Did you make any manual changes to your game folder (i.e., not via CKAN)?

Yes. Blackrack volumetric install via his instructions on his patreon page. Followed to the letter. I am wondering if the scatterer sunflare is the culprit, as both JNSQ and Volumetric reference scatterer, although I know very little and cannot find others with a similar problems in the CKAN github issues tab.

• https://www.patreon.com/posts/true-volumetric-139879553

Describe the bug

After installing Blackrack Volumetrics and its associated dependencies which is comprised of EVE, Scatterer, StockScattererconfigs, Stockvolumetricclouds, and Blackrack_TUFXconfig) I installed Deferred and TUFX via CKAN. I then loaded the game into a test save to ensure it worked and it did. Then I exited the game, opened CKAN, and attempted to install JNSQ. I was given the following message:

System.ArgumentException: Already contains module: JNSQ
   at CKAN.RelationshipResolver.Add(CkanModule module, SelectionReason reason)
   at CKAN.RelationshipResolver.AddModulesToInstall(CkanModule[] modules)
   at CKAN.RelationshipResolver..ctor(IEnumerable`1 modulesToInstall, IEnumerable`1 modulesToRemove, RelationshipResolverOptions options, IRegistryQuerier registry, IGame game, GameVersionCriteria versionCrit)
   at CKAN.IO.ModuleInstaller.InstallList(IReadOnlyCollection`1 modules, RelationshipResolverOptions options, RegistryManager registry_manager, HashSet`1& possibleConfigOnlyDirs, InstalledFilesDeduplicator deduper, String userAgent, IDownloader downloader, Boolean ConfirmPrompt)
   at CKAN.GUI.Main.InstallMods(Object sender, DoWorkEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnDoWork(DoWorkEventArgs e)
   at System.ComponentModel.BackgroundWorker.WorkerThreadStart(Object argument)
Your game folder has been returned to its original state.
Error during installation!

Steps to reproduce

• registry.json

1. Manually install Blackrack volumetrics.
2. Use CKAN to install TUFX and Deferred.
3. Then attempt to install JNSQ.

Relevant log output

No response

[HebaruSan]

Hi @DonnieDiggs, thanks for reporting this.

Can you please share the CKAN/registry.json file from your game folder? This would help us to investigate this problem.

Thanks!

[DonnieDiggs]

I will do so as soon as I am home from work. Thank you for your time.

[DonnieDiggs]

registry.json

Hello,

The registry file should be attached.

Just a heads up, I have since gotten the mods 'working' in game. However it was mostly not via CKAN. I think it will end up being an issue where a mod I asked CKAN to install (Scatterer) already had a different version or module installed as a dependency for a mod I installed manually (A config that makes Blackrack's Volumetrics work with JNSQ called JNSQVolumetrics). I really appreciate any time you took to look at this, but I think it is an avoidable problem, especially if JNSQVolumetrics ever gets added to CKAN without being bundled with Scatterer.

Thank you again!

[HebaruSan]

Hi @DonnieDiggs, thanks!
Do you still have the volumetric stuff installed? I ask because the installed_dlls property in your registry is empty; this is where CKAN tracks the manually installed DLLs that it finds, so I would have expected to see the volumetric stuff listed in there. I just wanted to confirm that investigating this specific registry.json file will actually shed light on the issue.

[DonnieDiggs]

I do still have all of it installed.

[HebaruSan]

OK, I just tried this with your registry, and CKAN just installed JNSQ normally.
Can you think of anything else we should know to be able to reproduce this?

[DonnieDiggs]

Nothing I can think of. I had run into issues with my previous KSP install and all the mods I was running, so I uninstalled it and started from scratch when I ran into this issue.

[HebaruSan]

Blackrack volumetric install via his instructions on his patreon page. Followed to the letter.

So @DonnieDiggs, can you give us a sense of what these instructions look like, for non-subscribers? Do they just tell you to extract some files from a ZIP, or do they also say to do things in CKAN? I'm still having absolutely no luck getting any sort of error or installation failure for JNSQ after many attempts, so we really need to know what you're doing differently from me.