Response to reviewi

Explicitly tell it I want an array instead of leaving it unspecified
which kind of Ienumerable it ends up being, to guarantee faster
calculation of Count() calls.  (I don't know if this is really needed,
given that partModule.Fields is of type BaseFields, which already does
implement a quick Count() get, but I admit I have no idea what C# does
when it executes a When clause, whether the subset it returns something
of exactly the same type as the original collection or whether it
makes a new IEnumerable collection out of it that might not be the
same kind.)

Author: Dunbaratu

src/kOS/Suffixed/PartModuleField/PartModuleFields.cs

@@ -239,8 +239,8 @@ protected BaseField GetField(string cookedGuiName)
             // with the given GUI name.  But Issue #2666 forced kOS to change it to a list of hits
             // because KSP started naming two fields with the same gui name, only one of which is visible
             // at a time:
-            IEnumerable<BaseField> allMatches = partModule.Fields.Cast<BaseField>().
-                Where(field => string.Equals(GetFieldName(field), cookedGuiName, StringComparison.CurrentCultureIgnoreCase));
+            BaseField[] allMatches = partModule.Fields.Cast<BaseField>().
+                Where(field => string.Equals(GetFieldName(field), cookedGuiName, StringComparison.CurrentCultureIgnoreCase)).ToArray<BaseField>();
             // When KSP is *not* doing the weird thing of two fields with the same name, there's just one hit and it's simple:
             if (allMatches.Count() == 1)
                 return allMatches.First();