I will probably abandon this branch - will use reflection

instead so it can tolerate having no ClickThruBlocker installed.

Author: Dunbaratu

CONTRIBUTING.md

@@ -213,7 +213,14 @@ Setting Up Your Environment
                * Click on the resulting link to go to that class's documentation page.
                * The Unity documentation for that class will start with some faint grey text at the top of the page that says, "Implemented in:", which tells you which DLL you need to reference to get code using that class to compile properly.
 
-	3. If you do not have a copy of KSP locally, you may
+        3. Make sure your installation of KSP has LinuxGuruGamer's ClivkThroughBlocker
+           mod installed.  kOS now needs it in order to compile.  After it is
+           installed, create a reference for it in your kOS project's References
+           like so:
+
+               * $KSP_INSTALL_DIR/GameData/00_ClickThroughBlocker/Plugins/ClickThroughBlocker.dll
+
+	4. If you do not have a copy of KSP locally, you may
 	  download dummy assemblies at https://github.com/KSP-KOS/KSP_LIB
 
 3. Make sure you are targeting this version of .Net:  ".Net 4.0 Framework".

src/kOS/Properties/AssemblyInfo.cs

@@ -34,3 +34,4 @@
 [assembly: AssemblyFileVersion("1.2.1.0")]
 [assembly: AssemblyVersion("1.2.1.0")]
 [assembly: KSPAssembly("kOS", 1, 7)]
+[assembly: KSPAssemblyDependency("ClickThroughBlocker", 1, 0)]

src/kOS/Screen/DelegateDialog.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 using UnityEngine;
 
 namespace kOS.Screen
@@ -38,7 +39,7 @@ public void OnGUI()
             if (invoked)
             {
                 float guessWidth = GUI.skin.label.CalcSize( new GUIContent(message) ).x;
-                GUILayout.Window( parent.GetUniqueId()+1, new Rect( parent.GetRect().xMin+200,
+                ClickThruBlocker.GUILayoutWindow( parent.GetUniqueId()+1, new Rect( parent.GetRect().xMin+200,
                                                  parent.GetRect().yMin+10,
                                                  guessWidth,
                                                  0) , DrawConfirm, "Confirm", GUILayout.ExpandWidth(true) );

src/kOS/Screen/GUIWindow.cs

@@ -14,6 +14,7 @@
 using kOS.Utilities;
 using kOS.Communication;
 using kOS.Safe;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 
 namespace kOS.Screen
 {
@@ -116,15 +117,15 @@ void OnGUI()
 
             GUI.skin = HighLogic.Skin;
 
-            WindowRect = GUILayout.Window(UniqueId, WindowRect, WidgetGui, TitleText, style);
+            WindowRect = ClickThruBlocker.GUILayoutWindow(UniqueId, WindowRect, WidgetGui, TitleText, style);
 
             if (currentPopup != null) {
                 var r = RectExtensions.EnsureCompletelyVisible(currentPopup.popupRect);
                 if (Event.current.type == EventType.MouseDown && !r.Contains(Event.current.mousePosition)) {
                     currentPopup.PopDown();
                 } else {
                     GUI.BringWindowToFront(UniqueId + 1);
-                    currentPopup.popupRect = GUILayout.Window(UniqueId + 1, r, PopupGui, "", style);
+                    currentPopup.popupRect = ClickThruBlocker.GUILayoutWindow(UniqueId + 1, r, PopupGui, "", style);
                 }
             }
         }

src/kOS/Screen/KOSManagedWindow.cs

@@ -1,14 +1,23 @@
 using System.Collections.Generic;
 using UnityEngine;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 
 namespace kOS.Screen
 {
     /// <summary>
     /// kOSManagedWindow is for any Unity Monobehavior that you'd like to
-    /// have contain a GUI.Window, and you need kOS to keep track of the
+    /// have contain an IMGUI Window, and you need kOS to keep track of the
     /// window stacking for which click is on top of which other click.
     /// Unity's built in systems for this don't work well at all, so
     /// we had to make up our own.
+    /// 
+    /// Issue #2697 - In addition to KOS's own system to handle this,
+    /// This also is now layered on top of Linuxgurugamer's ClickThroughBlocker
+    /// mod, so it uses its wrappers around GUI.Window.  That was needed because
+    /// if SOME mods use ClickThruBlocker windows, then those windows will get first
+    /// dibs on events before kOS gets to, making kOS helpless to intercept events it's
+    /// trying to protect other windows from seeing.  ClickThruBlocker is a mod that
+    /// once some mods use it, then all the other mods have to as well.
     /// </summary>
     public abstract class KOSManagedWindow : MonoBehaviour
     {

src/kOS/Screen/KOSNameTagWindow.cs

@@ -1,6 +1,7 @@
-using kOS.Utilities;
+using kOS.Utilities;
 using UnityEngine;
 using kOS.Module;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 using System;
 
 namespace kOS.Screen
@@ -124,7 +125,7 @@ public void OnGUI()
                 EditorLogic.fetch.Lock(false, false, false, "KOSNameTagLock");
 
             GUI.skin = HighLogic.Skin;
-            GUILayout.Window(myWindowId, windowRect, DrawWindow,"KOS nametag");
+            ClickThruBlocker.GUILayoutWindow(myWindowId, windowRect, DrawWindow,"KOS nametag");
 
             // Ensure that the first time the window is made, it gets keybaord focus,
             // but allow the focus to leave the window after that:

src/kOS/Screen/KOSTextEditPopup.cs

@@ -6,6 +6,7 @@
 using kOS.Safe.Exceptions;
 using kOS.Safe.Utilities;
 using kOS.Module;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 
 namespace kOS.Screen
 {
@@ -170,7 +171,7 @@ public void OnGUI()
             CalcOuterCoords(); // force windowRect to lock to bottom edge of the parents
             CalcInnerCoords();
 
-            WindowRect = GUI.Window(UniqueId, WindowRect, ProcessWindow, "");
+            WindowRect = ClickThruBlocker.GUIWindow(UniqueId, WindowRect, ProcessWindow, "");
             // Some mouse global state data used by several of the checks:
 
             if (consumeEvent)

src/kOS/Screen/KOSToolbarWindow.cs

@@ -10,6 +10,8 @@
 using System.Collections.Generic;
 using System.Linq;
 using UnityEngine;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
+
 
 namespace kOS.Screen
 {
@@ -443,7 +445,7 @@ public void OnGUI()
 
             GUI.skin = HighLogic.Skin;
 
-            windowRect = GUILayout.Window(UNIQUE_ID, windowRect, DrawWindow, "kOS " + versionString);
+            windowRect = ClickThruBlocker.GUILayoutWindow(UNIQUE_ID, windowRect, DrawWindow, "kOS " + versionString);
             windowRect = RectExtensions.ClampToRectAngle(windowRect, rectToFit);
         }
 

src/kOS/Screen/ListPickerDialog.cs

@@ -1,5 +1,7 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using UnityEngine;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
+
 
 namespace kOS.Screen
 {
@@ -110,7 +112,7 @@ public void OnGUI()
 
             // Make sure it shifts enough to the left to fit the biggest string:
             outerWindowRect.x = Mathf.Min(outerWindowRect.x, UnityEngine.Screen.width - outerWindowRect.width - 60);
-            outerWindowRect = GUILayout.Window(
+            outerWindowRect = ClickThruBlocker.GUILayoutWindow(
                 title.GetHashCode(),
                 outerWindowRect,
                 DrawInnards,

src/kOS/Screen/TermWindow.cs

@@ -10,6 +10,7 @@
 using kOS.Safe.UserIO;
 using KSP.UI.Dialogs;
 using kOS.Safe.Utilities;
+using ClickThroughFix; // Needs ClickThroughBlocker DLL to be in the Reference directory.
 
 namespace kOS.Screen
 {
@@ -360,7 +361,7 @@ void OnGUI()
             // Should probably make "gui screen name for my CPU part" into some sort of utility method:
             ChangeTitle(CalcualteTitle());
 
-            WindowRect = GUI.Window(UniqueId, WindowRect, TerminalGui, TitleText);
+            WindowRect = ClickThruBlocker.GUIWindow(UniqueId, WindowRect, TerminalGui, TitleText);
 
             if (consumeEvent)
             {