Merge branch 'dev'

Author: Capkirk123

.github/workflows/msbuild.yml

@@ -18,7 +18,7 @@ jobs:
   # This workflow contains a single job called "build"
   build:
     # The type of runner that the job will run on
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
@@ -74,7 +74,7 @@ jobs:
           cp -v -R "${GITHUB_WORKSPACE}/GameData" "${RELEASE_DIR}"
 
       - name: Upload artifacts
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
           name: TestFlight
           path: ${{ steps.assemble-release.outputs.release-dir }}

.github/workflows/pr-comment.yml

@@ -6,7 +6,7 @@ on:
 jobs:
   pr_comment:
     if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/github-script@v3
         with:

.github/workflows/release.yml

@@ -10,7 +10,7 @@ jobs:
   tagged-release:
     name: "Tagged Release"
     # The type of runner that the job will run on
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:

TestFlightAPI/TestFlightAPI/TestFlightFailure.cs

@@ -22,6 +22,8 @@ public class TestFlightFailureBase : PartModule, ITestFlightFailure
         [KSPField]
         public float duFail = 0f;
         [KSPField]
+        public float duSucceed = 0f;
+        [KSPField]
         public float duRepair = 0f;
         [KSPField]
         public bool oneShot = false;
@@ -163,6 +165,7 @@ public virtual void SetActiveConfig(string alias)
             currentConfig.TryGetValue("weight", ref weight);
             currentConfig.TryGetValue("failureTitle", ref failureTitle);
             currentConfig.TryGetValue("duFail", ref duFail);
+            currentConfig.TryGetValue("duSucceed", ref duSucceed);
             currentConfig.TryGetValue("duRepair", ref duRepair);
             currentConfig.TryGetValue("oneShot", ref oneShot);
             currentConfig.TryGetValue("awardDuInPreLaunch", ref awardDuInPreLaunch);

TestFlightFailure_IgnitionFail.cs

@@ -275,6 +275,7 @@ public override void OnUpdate()
                         }
                         else
                         {
+                            OnIgnition();
                             engineData.hasBeenRun = true;
                         }
                     }
@@ -648,6 +649,19 @@ private void ShowRestartWindowPenaltyInfo(string sPenaltyPercent)
             TestFlightGameSettings tfSettings = HighLogic.CurrentGame.Parameters.CustomParams<TestFlightGameSettings>();
             tfSettings.restartWindowPenaltyReminderShown = restartWindowPenaltyReminderShown = true;
         }
+
+        private void OnIgnition()
+        {
+            if (core.GetFlightData() == core.GetInitialFlightData() && (vessel.situation != Vessel.Situations.PRELAUNCH || awardDuInPreLaunch)) //Only award DU on the first ignition of each flight, and only when not attached to launch clamps.
+            {
+                float ignitionDU = Mathf.Max(duSucceed, core.GetMaximumData() / 40);
+                if (verboseDebugging)
+                {
+                    Log($"IgnitionFail: Awarding successful ignition DU: {ignitionDU:F4}");
+                }
+                core.ModifyFlightData(ignitionDU, true); //Award DU for first successful ignition
+            }
+        }
     }
 }