FIX: Data in the VAB now includes transfer and research data pools

FIX: Some modules were pulling the old data which didn't include the new pools

Author: jwvanderbeck

GameData/TestFlight/Plugins/TestFlight.dll

@@ -1275,7 +1275,8 @@ public List<string> GetTestFlightInfo()
             string partName = Alias;
             infoStrings.Add("<b>Core</b>");
             infoStrings.Add(indent + "  <b>Active Part</b>: " + partName);
-            float flightData = TestFlightManagerScenario.Instance.GetFlightDataForPartName(partName);
+            // float flightData = TestFlightManagerScenario.Instance.GetFlightDataForPartName(partName);
+            var flightData = GetFlightData();
             if (flightData < 0f)
                 flightData = 0f;
             infoStrings.Add(indent + String.Format("  <b>Flight Data</b>: {0:f1}/{1:f1}", flightData, maxData));
@@ -1373,6 +1374,14 @@ public void UpdatePartConfig()
                 testFlightModules[i].enabled = enabled;
             }
 
+
+            if (TestFlightManagerScenario.Instance.SettingsAlwaysMaxData)
+                InitializeFlightData(maxData);
+            else
+            {
+                InitializeFlightData(Mathf.Max(0, TestFlightManagerScenario.Instance.GetFlightDataForPartName(Alias)));
+            }
+            
             if (Events == null)
                 return;
 

GameData/TestFlight/Plugins/TestFlightCore.dll

@@ -312,12 +312,12 @@ internal override void DrawWindow(int id)
             GUILayout.BeginVertical();
             GUILayout.Label(String.Format("Selected Part: {0}", selectedAlias), Styles.styleEditorTitle);
 
-            float flightData = TestFlightManagerScenario.Instance.GetFlightDataForPartName(selectedAlias);
-            if (flightData < 0f)
-                flightData = 0f;
             core = TestFlightUtil.GetCore(SelectedPart, selectedAlias);
             if (core != null)
             {
+                float flightData = core.GetFlightData();
+                if (flightData < 0f)
+                    flightData = 0f;
                 core.InitializeFlightData(flightData);
                 GUILayout.BeginHorizontal();
                 double failureRate = core.GetBaseFailureRate();

TestFlightCore/TestFlightCore/TestFlightCore.cs

@@ -324,7 +324,7 @@ public override List<string> GetTestFlightInfo()
                 return infoStrings;
             }
 
-            float flightData = TestFlightManagerScenario.Instance.GetFlightDataForPartName(Configuration);
+            float flightData = core.GetFlightData();
             if (flightData < 0f)
                 flightData = 0f;
 

TestFlightCore/TestFlightCore/TestFlightEditor.cs

@@ -53,7 +53,7 @@ public override List<string> GetTestFlightInfo(float reliabilityAtTime)
                 return infoStrings;
             }
 
-            float flightData = TestFlightManagerScenario.Instance.GetFlightDataForPartName(Configuration);
+            float flightData = core.GetFlightData();
             if (flightData < 0f)
                 flightData = 0f;