Better logging, actually make the loading flow actions in a sane way

Author: cheese3660

Runtime/Core/Assets/PatchingManager.cs

@@ -232,7 +232,7 @@ private static AsyncOperationHandle<IList<TextAsset>> RebuildCache(string label)
                 }
                 catch (Exception e)
                 {
-                    Logging.LogError($"Unable to patch {asset.name} due to: {e.Message}");
+                    Logging.LogError($"Unable to patch {asset.name} due to: {e.Message}, {e.StackTrace}");
                 }
             });
 
@@ -318,29 +318,19 @@ GenericFlowAction CreateIndexedFlowAction(int idx)
                     (resolve2, _) =>
                     {
                         var handle = RebuildCache(distinctKeys[idx]);
-                        var killTips = false;
-                        if (idx + 1 < distinctKeys.Count)
-                        {
-                            GameManager.Instance.LoadingFlow.FlowActions.Insert(
-                                GameManager.Instance.LoadingFlow.flowIndex + 1,
-                                CreateIndexedFlowAction(idx + 1)
-                            );
-                        }
-                        else
-                        {
-                            killTips = true;
-                        }
-
-                        CoroutineUtil.Instance.DoCoroutine(WaitForCacheRebuildSingleHandle(handle, resolve2, killTips));
+                        CoroutineUtil.Instance.DoCoroutine(WaitForCacheRebuildSingleHandle(handle, resolve2, idx + 1 == distinctKeys.Count));
                     });
             }
 
             if (distinctKeys.Count > 0)
             {
-                GameManager.Instance.LoadingFlow.FlowActions.Insert(
-                    GameManager.Instance.LoadingFlow.flowIndex + 1,
-                    CreateIndexedFlowAction(0)
-                );
+                for (var i = distinctKeys.Count - 1; i >= 0; i--)
+                {
+                    GameManager.Instance.LoadingFlow.FlowActions.Insert(
+                        GameManager.Instance.LoadingFlow.flowIndex + 1,
+                        CreateIndexedFlowAction(i)
+                    );
+                }
             }
 
             resolve();

Runtime/SassyPatching/Execution/Universe.cs

@@ -645,7 +645,7 @@ public string RunAllPatchesFor(string label, string name, string data, out int p
                 catch (Exception e)
                 {
                     errorCount += 1;
-                    ErrorLogger($"Patching {label}:{name} failed due to {e}");
+                    ErrorLogger($"Patching {label}:{name} failed due to {e.Message}");
                 }
             }
 
@@ -670,7 +670,7 @@ public string RunAllPatchesFor(string label, string name, ISelectable selectable
                 catch (Exception e)
                 {
                     errorCount += 1;
-                    ErrorLogger($"Patching {label}:{name} failed due to {e}");
+                    ErrorLogger($"Patching {label}:{name} failed due to {e.Message}");
                 }
             }
             return selectable.Serialize();