Fix #391: remove complex stringbuilder caching

-also try to optimize a few spots where strings were rebuilt

Author: JonnyOThan

SCANsat/SCAN_UI/UI_Framework/SCANStringBuilderCache.cs

@@ -415,34 +415,8 @@ internal static void getMouseOverElevation(StringBuilder sb, double Lon, double
 
 		/* UI: conversions to and from DMS */
 		/* FIXME: These do not belong here. And they are only used once! */
-		private static string toDMS(double thing, char neg, char pos, int prec)
-		{
-			StringBuilder sb = SCANStringBuilderCache.Acquire();
 
-			if (thing >= 0)
-			{
-				neg = pos;
-			}
-
-			thing = Math.Abs(thing);
-
-			sb.Append(Math.Floor(thing).ToString());
-			sb.Append(HOURS);
-			thing = (thing - Math.Floor(thing)) * 60;
-
-			sb.Append(Math.Floor(thing).ToString());
-			sb.Append(MINUTES);
-			thing = (thing - Math.Floor(thing)) * 60;
-
-			sb.Append(thing.ToString(string.Format("F{0}", prec.ToString())));
-			sb.Append(SECONDS);
-
-			sb.Append(neg);
-
-			return sb.SCANToStringAndRelease();
-		}
-
-		private static void toDMS(StringBuilder sb, double thing, char neg, char pos)
+		private static void toDMS(StringBuilder sb, double thing, char neg, char pos, string precFormat = "F2")
 		{
 			if (thing >= 0)
 			{
@@ -459,17 +433,12 @@ private static void toDMS(StringBuilder sb, double thing, char neg, char pos)
 			sb.Append(MINUTES);
 			thing = (thing - Math.Floor(thing)) * 60;
 
-			sb.Append(thing.ToString("F2"));
+			sb.Append(thing.ToString(precFormat));
 			sb.Append(SECONDS);
 
 			sb.Append(neg);
 		}
 
-		internal static string toDMS(double lat, double lon, int precision = 2)
-		{
-			return string.Format("{0} {1}", toDMS(lat, SOUTH, NORTH, precision), toDMS(lon, WEST, EAST, precision));
-		}
-
 		internal static void toDMS(StringBuilder sb, double lat, double lon)
 		{
 			toDMS(sb, lat, SOUTH, NORTH);

SCANsat/SCAN_UI/UI_Framework/SCANuiUtil.cs

@@ -50,6 +50,7 @@ public class SCAN_UI_Overlay : ISCAN_Overlay
 		private volatile bool terrainGenerated;
 
 		private StringBuilder tooltipText = new StringBuilder();
+		private string tooltipString = string.Empty;
 		private bool tooltipActive;
 
 		private Texture2D mapOverlay;
@@ -193,7 +194,7 @@ private void MouseOverTooltip(SCANUtil.SCANCoordinates coords)
 
 			tooltipText.Length = 0;
 
-			tooltipText.Append(coords.ToDMS());
+			coords.ToDMS(tooltipText);
 
 			if (body.pqsController != null)
 			{
@@ -239,6 +240,8 @@ private void MouseOverTooltip(SCANUtil.SCANCoordinates coords)
 				tooltipText.AppendLine();
 				tooltipText.Append(SCANuiUtil.getResourceAbundance(body, coords.latitude, coords.longitude, fuzzy, currentResource));
 			}
+
+			tooltipString = tooltipText.ToString();
 		}
 
 		public void Open()
@@ -260,7 +263,7 @@ public void Open()
 
 			uiElement.SetOverlay(this);
 
-			tooltipText = SCANStringBuilderCache.Acquire();
+			tooltipString = string.Empty;
 
 			_isVisible = true;
 
@@ -307,7 +310,7 @@ public string CurrentResource
 
 		public string TooltipText
 		{
-			get { return tooltipText.SCANToStringAndRelease(); }
+			get { return tooltipString; }
 		}
 
 		public bool IsVisible

SCANsat/SCAN_Unity/SCAN_UI_Overlay.cs

@@ -1269,7 +1269,12 @@ public string ZoomLevelText
 
 		public string MapCenterText
 		{
-			get { return SCANuiUtil.toDMS(spotmap.CenteredLat, spotmap.CenteredLong); }
+			get
+			{
+				infoString.Clear();
+				SCANuiUtil.toDMS(infoString, spotmap.CenteredLat, spotmap.CenteredLong);
+				return infoString.ToString();
+			}
 		}
 
 		public string RandomWaypoint

SCANsat/SCAN_Unity/SCAN_UI_ZoomMap.cs

@@ -1334,9 +1334,9 @@ public string ToDegString()
 				return latitude.ToString("F1") + "°, " + longitude.ToString("F1") + "°";
 			}
 
-			public string ToDMS()
+			public void ToDMS(StringBuilder sb)
 			{
-				return SCANuiUtil.toDMS(latitude, longitude, 0);
+				SCANuiUtil.toDMS(sb, latitude, longitude);
 			}
 		}