Fix #432: don't use normal maps in visual map for parallax continued

Author: JonnyOThan

CHANGELOG.md

@@ -1,6 +1,6 @@
 # SCANsat Changelog
 
-## 21.0 - 2025-09-15
+## Unreleased
 
 - Added Chinese localization (thanks @AmazingWood)
 - Fixed usages of .material in favor of .sharedMaterial (thanks @Gameslinx)

SCANsat/SCAN_Reflection/SCANparallaxContinued.cs

@@ -60,9 +60,28 @@ internal static void LoadParallax(CelestialBody body, ref Material material)
 					Log.Message($"Loading Parallax Continued data for {body.name}");
 					x_ParallaxScaledBody_Load.Invoke(parallaxBody, null);
 					material = x_ParallaxScaledBody_scaledMaterial.GetValue(parallaxBody) as Material;
+
+#if DEBUG
+					for (int propertyIndex = 0; propertyIndex < material.shader.GetPropertyCount(); ++propertyIndex)
+					{
+						var propertyType = material.shader.GetPropertyType(propertyIndex);
+						var propertyName = material.shader.GetPropertyName(propertyIndex);
+						object propertyValue = null;
+
+						switch (propertyType)
+						{
+							case UnityEngine.Rendering.ShaderPropertyType.Color: propertyValue = material.GetColor(propertyName); break;
+							case UnityEngine.Rendering.ShaderPropertyType.Vector: propertyValue = material.GetVector(propertyName); break;
+							case UnityEngine.Rendering.ShaderPropertyType.Float: propertyValue = material.GetFloat(propertyName); break;
+							case UnityEngine.Rendering.ShaderPropertyType.Range: propertyValue = material.GetFloat(propertyName); break;
+							case UnityEngine.Rendering.ShaderPropertyType.Texture: propertyValue = material.GetTexture(propertyName); break;
+						}
+
+						Log.Debug($"Property {propertyIndex} is {propertyType} named {propertyName} with value {propertyValue}");
+					}
+#endif
 				}
 			}
-
 		}
 	}
 }

SCANsat/SCANcontroller.cs

@@ -1600,11 +1600,12 @@ internal void LoadVisualMapTexture(CelestialBody b, mapSource s)
 
 		}
 
-		void GetVisualMapTexturesForBody(CelestialBody b, out Material material, out string colorMapTextureName, out string normalMapTextureName)
+		void GetVisualMapTexturesForBody(CelestialBody b, out Material material, out bool useMaterialForColorMap, out string colorMapTextureName, out string normalMapTextureName)
 		{
 			material = null;
 			colorMapTextureName = null;
 			normalMapTextureName = null;
+			useMaterialForColorMap = true;
 
 			if (b.scaledBody == null)
 			{
@@ -1630,7 +1631,10 @@ void GetVisualMapTexturesForBody(CelestialBody b, out Material material, out str
 			else if (shaderName.Contains("ParallaxScaled"))
 			{
 				SCANparallaxContinued.LoadParallax(b, ref material);
+				useMaterialForColorMap = false;
 				colorMapTextureName = "_ColorMap";
+				normalMapTextureName = null; // for whatever reason, the logic in ScANmap that uses the normal map doesn't work with parallax's normal maps
+				return;
 			}
 			else if (material.HasProperty("_MainTex"))
 			{
@@ -1662,7 +1666,7 @@ void CacheScaledSpaceTexture(Dictionary<CelestialBody, Texture2D> cache, Celesti
 				}
 				else
 				{
-					var colorMap = sourceTexture.isReadable ? sourceTexture : readableTexture(sourceTexture, material, true);
+					var colorMap = sourceTexture.isReadable ? sourceTexture : readableTexture(sourceTexture, useMaterial ? material : null);
 					cache.Add(b, colorMap);
 				}
 			}
@@ -1680,15 +1684,15 @@ internal void LoadVisualMapTexture_Renamed(CelestialBody b, mapSource s)
 				return;
 			}
 
-			GetVisualMapTexturesForBody(b, out Material material, out string colorMapTextureName, out string normalMapTextureName);
+			GetVisualMapTexturesForBody(b, out Material material, out bool useMaterialForColorMap, out string colorMapTextureName, out string normalMapTextureName);
 
 			if (material == null)
 			{
 				Log.Error($"GetVisualMapTexturesForBody returned a null material for body {b.name}");
 			}
 			else
 			{
-				CacheScaledSpaceTexture(readableScaledSpaceMaps, b, material, colorMapTextureName, true);
+				CacheScaledSpaceTexture(readableScaledSpaceMaps, b, material, colorMapTextureName, useMaterialForColorMap);
 				CacheScaledSpaceTexture(readableScaledSpaceNormalMaps, b, material, normalMapTextureName, false);
 			}
 
@@ -1752,7 +1756,7 @@ internal void UnloadVisualMapTexture(CelestialBody b, mapSource s)
 			}
 		}
 
-		private Texture2D readableTexture(Texture tex, Material mat, bool useMat)
+		private Texture2D readableTexture(Texture tex, Material mat)
 		{
 			if (tex == null)
 			{
@@ -1763,7 +1767,7 @@ private Texture2D readableTexture(Texture tex, Material mat, bool useMat)
 
 			var rt = RenderTexture.GetTemporary(tex.width, tex.height, 0, RenderTextureFormat.ARGB32, RenderTextureReadWrite.sRGB, 1);
 
-			if (useMat)
+			if (mat != null)
 			{
 				Graphics.Blit(tex, rt, mat);
 			}