Drop JsonPoke requirement for version-file generation #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, especially because I think jsonpoke isn’t available for non-sdk projects. I’ll have to go over it in more detail and hopefully drew can take a look too since he set that stuff up initially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
JsonPoke isn't technically required, and while it is beneficial to use something that's specifically meant for JSON file writing, we don't really need it.
Modifications
WriteLinesToFile. This did require a little hacky fix for proper indention, but it's not that hacky in my opinion. WhileWriteLinesToFiledoesn't specifically support writing JSON, we aren't really writing much JSON in the first place.Results