a best-effort attempt at recovering property names for diagnostics

Author: al2me6

Source/DynamicProperties/Patches/PartPatch.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using HarmonyLib;
+using UnityEngine;
 
 namespace Shabby;
 
@@ -22,6 +23,7 @@ private static void CreateRendererLists_Postfix(Part __instance)
 		var props = highlightProperties[__instance];
 		props.SetFloat(PropertyIDs._RimFalloff, 2f);
 		props.SetColor(PropertyIDs._RimColor, Part.defaultHighlightNone);
+		props.SetColor(PropertyIDs._Color, Color.red);
 		foreach (var renderer in __instance.HighlightRenderer) {
 			MaterialPropertyManager.Instance.Set(renderer, props);
 		}
@@ -37,6 +39,25 @@ private static bool SetOpacity_Prefix(Part __instance, float opacity)
 		return false;
 	}
 
+	// [HarmonyTranspiler]
+	// [HarmonyPatch(nameof(Part.Highlight))]
+	// private static IEnumerable<CodeInstruction> Highlight_Transpiler(
+	// 	IEnumerable<CodeInstruction> insns)
+	// {
+	// 	var Renderer_SetPropertyBlock =
+	// 		AccessTools.Method(typeof(Renderer), nameof(Renderer.SetPropertyBlock));
+	//
+	// 	var matcher = new CodeMatcher(insns);
+	// 	matcher.MatchStartForward(
+	// 		Code.Ldarg_0,
+	// 		new CodeMatch(CodeInstruction.LoadField(typeof(Part), nameof(Part.highlightRenderer))),
+	// 		Code.Ldloc,
+	// 		Code.Call,
+	//
+	// 	);
+	// 	return matcher.Instructions();
+	// }
+
 	[HarmonyPostfix]
 	[HarmonyPatch("OnDestroy")]
 	private static void OnDestroy_Postfix(Part __instance)

Source/DynamicProperties/Props.cs

@@ -1,10 +1,53 @@
 using System.Collections.Generic;
+using System.Linq;
 using System.Runtime.CompilerServices;
 using KSPBuildTools;
 using UnityEngine;
 
 namespace Shabby;
 
+internal static class PropIdToName
+{
+	private static readonly string[] CommonProperties = [
+		"TransparentFX",
+		"_BumpMap",
+		"_Color",
+		"_EmissiveColor",
+		"_MainTex",
+		"_MaxX",
+		"_MaxY",
+		"_MinX",
+		"_MinY",
+		"_Multiplier",
+		"_Opacity",
+		"_RimColor",
+		"_RimFalloff",
+		"_TC1Color",
+		"_TC1MetalBlend",
+		"_TC1Metalness",
+		"_TC1SmoothBlend",
+		"_TC1Smoothness",
+		"_TC2Color",
+		"_TC2MetalBlend",
+		"_TC2Metalness",
+		"_TC2SmoothBlend",
+		"_TC2Smoothness",
+		"_TemperatureColor",
+		"_Tex",
+		"_Tint",
+		"_TintColor",
+		"_subdiv",
+		"localMatrix",
+		"upMatrix"
+	];
+
+	private static readonly Dictionary<int, string> IdToName =
+		CommonProperties.ToDictionary(Shader.PropertyToID, name => name);
+
+	internal static string Get(int id) =>
+		IdToName.TryGetValue(id, out var name) ? name : $"<{id}>";
+}
+
 internal abstract class Prop;
 
 internal class Prop<T>(T value) : Prop
@@ -38,10 +81,6 @@ public sealed class Props(int priority)
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
 	private void _internalSet<T>(int id, T value)
 	{
-		Dirty = true;
-
-		MaterialPropertyManager.Instance.LogDebug($"setting {id} to {value}");
-
 		if (!_props.TryGetValue(id, out var prop)) {
 			_props[id] = new Prop<T>(value);
 			Changed = true;
@@ -50,7 +89,7 @@ private void _internalSet<T>(int id, T value)
 
 		if (prop is not Prop<T> propT) {
 			MaterialPropertyManager.Instance.LogWarning(
-				$"property {id} has mismatched type; overwriting with {typeof(T).Name}!");
+				$"property {PropIdToName.Get(id)} has mismatched type; overwriting with {typeof(T).Name}!");
 			_props[id] = new Prop<T>(value);
 			Changed = true;
 			return;
@@ -85,9 +124,12 @@ private void _internalSet<T>(int id, T value)
 	internal void Write(int id, MaterialPropertyBlock mpb)
 	{
 		if (!_props.TryGetValue(id, out var prop)) {
-			throw new KeyNotFoundException($"property {id} not found");
+			throw new KeyNotFoundException($"property {PropIdToName.Get(id)} not found");
 		}
 
+		MaterialPropertyManager.Instance.LogDebug(
+			$"writing property {PropIdToName.Get(id)} = {prop}");
+
 		switch (prop) {
 			case Prop<Color> c: mpb.SetColor(id, c.Value); break;
 			case Prop<float> f: mpb.SetFloat(id, f.Value); break;
@@ -102,7 +144,7 @@ public override string ToString()
 		var sb = StringBuilderCache.Acquire();
 		sb.AppendFormat("(Priority {0}) {{\n", Priority);
 		foreach (var (id, prop) in _props) {
-			sb.AppendFormat("{0} = {1}\n", id, prop);
+			sb.AppendFormat("{0} = {1}\n", PropIdToName.Get(id), prop);
 		}
 
 		sb.AppendLine("}");