mod: optimizing patch detail page metadata

Author: KUN1007

.vscode/settings.json

@@ -2,6 +2,7 @@
   "cSpell.words": [
     "abcdefghjkmnopqrstuvwxyzABCDEFGHJKLMNOPQRSTUVWXYZ",
     "Alcot",
+    "alttitle",
     "anidb",
     "atrule",
     "autoincrement",
@@ -93,6 +94,7 @@
     "Nyaa",
     "nyne",
     "Nysoure",
+    "olang",
     "onedrive",
     "opendal",
     "optimizelegibility",

app/patch/[id]/comment/metadata.ts

@@ -1,12 +1,20 @@
 import { kunMoyuMoe } from '~/config/moyu-moe'
+import { getPreferredLanguageText } from '~/utils/getPreferredLanguageText'
 import type { Metadata } from 'next'
 import type { KunSiteAuthor } from '~/config/config'
-import type { Patch, PatchComment } from '~/types/api/patch'
+import type { PatchHeader, PatchComment } from '~/types/api/patch'
 
 export const generateKunMetadataTemplate = (
-  patch: Patch,
+  patch: PatchHeader,
   comments: PatchComment[]
 ): Metadata => {
+  const patchName = getPreferredLanguageText(patch.name)
+  const patchNameJa = patch.name['ja-jp'] ? patch.name['ja-jp'] : ''
+  const pageTitle =
+    patchNameJa && patchName !== patchNameJa
+      ? `${patchName} | ${patchNameJa} 的评论和评价`
+      : `${patchName} 的评论和评价`
+
   const authors: KunSiteAuthor[] = comments.map((com) => ({
     name: com.user.name,
     url: `${kunMoyuMoe.domain.main}/user/${com.user.id}/resource`
@@ -17,24 +25,20 @@ export const generateKunMetadataTemplate = (
   )
   const uniqueAuthorsName = uniqueAuthors.map((u) => u.name)
 
+  const pageDescription = comments.length
+    ? `${uniqueAuthorsName} 在 ${patchName} 下发布了 ${comments[0].content} 等评论, 查看更多`
+    : `点击查看 ${patchName} 下的评论`
+
   return {
-    title: patch.alias.length
-      ? `${patch.name} | ${patch.alias[0]} 的 评论`
-      : `${patch.name} 的 评论`,
+    title: pageTitle,
     keywords: [...patch.alias, '评论'],
     authors: uniqueAuthors,
     creator: patch.user.name,
     publisher: patch.user.name,
-    description: comments.length
-      ? `${uniqueAuthorsName} 在 ${patch.name} 下发布了 ${comments[0].content} 等评论, 查看更多`
-      : `点击查看 ${patch.name} 下的评论`,
+    description: pageDescription,
     openGraph: {
-      title: patch.alias.length
-        ? `${patch.name} | ${patch.alias[0]} 的 评论`
-        : `${patch.name} 的 评论`,
-      description: comments.length
-        ? `${uniqueAuthorsName} 在 ${patch.name} 下发布了 ${comments[0].content} 等评论, 查看更多`
-        : `点击查看 ${patch.name} 下的评论`,
+      title: pageTitle,
+      description: pageDescription,
       type: 'article',
       publishedTime: patch.created,
       modifiedTime: patch.updated,
@@ -43,18 +47,14 @@ export const generateKunMetadataTemplate = (
           url: patch.banner,
           width: 1920,
           height: 1080,
-          alt: patch.name
+          alt: patchName
         }
       ]
     },
     twitter: {
       card: 'summary',
-      title: patch.alias.length
-        ? `${patch.name} | ${patch.alias[0]} 的 评论`
-        : `${patch.name} 的 评论`,
-      description: comments.length
-        ? `${uniqueAuthorsName} 在 ${patch.name} 下发布了 ${comments[0].content} 等评论, 查看更多`
-        : `点击查看 ${patch.name} 下的评论`,
+      title: pageTitle,
+      description: pageDescription,
       images: [patch.banner]
     },
     alternates: {

app/patch/[id]/history/actions.ts

@@ -6,15 +6,22 @@ import type { PatchDetail } from '~/types/api/patch'
 
 export const generateKunMetadataTemplate = (detail: PatchDetail): Metadata => {
   const patchName = getPreferredLanguageText(detail.name)
+  const patchNameJa = detail.name['ja-jp'] ? detail.name['ja-jp'] : ''
+  const pageTitle =
+    patchNameJa && patchName !== patchNameJa
+      ? `${patchName} | ${patchNameJa}`
+      : `${patchName}`
   const patchIntro = convert(getPreferredLanguageText(detail.introduction), {
     wordwrap: false,
     selectors: [{ selector: 'p', format: 'inline' }]
   }).slice(0, 170)
 
   return {
+    title: pageTitle,
     keywords: [patchName, ...detail.alias.map((a) => a.name)],
     description: patchIntro.slice(0, 170),
     openGraph: {
+      title: pageTitle,
       description: patchIntro.slice(0, 170),
       type: 'article',
       images: [
@@ -28,6 +35,7 @@ export const generateKunMetadataTemplate = (detail: PatchDetail): Metadata => {
     },
     twitter: {
       card: 'summary',
+      title: pageTitle,
       description: patchIntro.slice(0, 170),
       images: [detail.banner]
     },

app/patch/[id]/history/metadata.ts

@@ -4,29 +4,14 @@ import {
   kunGetPatchIntroductionActions,
   kunUpdatePatchViewsActions
 } from './actions'
-import { generateKunMetadataTemplate } from './metadata'
 import { PatchContainer } from '~/components/patch/Container'
 import { verifyHeaderCookie } from '~/utils/actions/verifyHeaderCookie'
-import type { Metadata } from 'next'
 
 interface Props {
   children: React.ReactNode
   params: Promise<{ id: string }>
 }
 
-export const generateMetadata = async ({
-  params
-}: Props): Promise<Metadata> => {
-  const { id } = await params
-  const patch = await kunGetPatchActions({
-    patchId: Number(id)
-  })
-  if (typeof patch === 'string') {
-    return {}
-  }
-  return generateKunMetadataTemplate(patch)
-}
-
 export default async function Kun({ params, children }: Props) {
   const { id } = await params