Skip to content

Commit 39d6de9

Browse files
authored
Remove unused models file (#898)
With the move to `kagglesdk` and the generated Python bindings, a lot of the files under [src/kaggle/models/](https://github.com/Kaggle/kaggle-api/tree/main/src/kaggle/models) were unused. Also, [ApiDatasetColumn](https://github.com/Kaggle/kagglesdk/blob/851d58d5afea0568d52338cbdb0cb6c8ce7569e2/kagglesdk/datasets/types/dataset_api_service.py#L1063) (generated from kagglesdk) and [DatasetColumn](https://github.com/Kaggle/kaggle-api/blob/main/src/kaggle/models/dataset_column.py) were used interchangeably in [kaggle_api_extended.py](https://github.com/Kaggle/kaggle-api/blob/main/src/kaggle/api/kaggle_api_extended.py). Make sure we always use the auto-generated class and deleted the other one. http://b/476473628
1 parent 24b7524 commit 39d6de9

16 files changed

+9
-4114
lines changed

src/kaggle/api/kaggle_api_extended.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@
149149
from kagglesdk.models.types.model_enums import ListModelsOrderBy, ModelInstanceType, ModelFramework
150150
from kagglesdk.models.types.model_types import Owner
151151
from kagglesdk.security.types.oauth_service import IntrospectTokenRequest
152-
from ..models.dataset_column import DatasetColumn
153152
from ..models.upload_file import UploadFile
154153
import kagglesdk.kaggle_client
155154
from enum import EnumMeta
@@ -4818,11 +4817,12 @@ def process_column(self, column):
48184817
column: A list of values in a column to be processed.
48194818
48204819
Returns:
4821-
A DatasetColumn object.
4820+
An ApiDatasetColumn object.
48224821
"""
4823-
processed_column = DatasetColumn(
4824-
name=self.get_or_fail(column, "name"), description=self.get_or_default(column, "description", "")
4825-
)
4822+
processed_column = ApiDatasetColumn()
4823+
processed_column.name = self.get_or_fail(column, "name")
4824+
processed_column.description = self.get_or_default(column, "description", "")
4825+
48264826
if "type" in column:
48274827
original_type = column["type"].lower()
48284828
processed_column.original_type = original_type

src/kaggle/models/api_blob_type.py

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/kaggle/models/dataset_column.py

Lines changed: 0 additions & 228 deletions
This file was deleted.

0 commit comments

Comments
 (0)