Transformations activate while using fly-cam mode

[4g10w]

Describe the bug
If you press any transformation button (G/R/S) while using fly-cam (RMB) and object(s) selected, the transformation will attempt to be activated even if that's not immediately obvious. the respective transformation will begin upon releasing RMB.

• Grabbing with G works right away and you begin to move your object around while rotating the camera in fly-cam mode.
  Fixed, however Grab-operation will still start if you release RMB while holding G.
• Rotating with R doesn't rotate the object at first, however if you're persistent and hold R for longer while looking around (moving mouse around), the camera will begin to stutter until stopped altogether. Then if you release RMB, rotation will begin.
  This appears to be it's own different bug unrelated to transformation operations and is made into it's own separate issue: Fly-cam stutters when looking around #571. Holding R while releasing RMB will begin Rotation-operation though.
• If you move back with S while releasing the fly-cam RMB, the scaling operation for the selected object will be initiated.

To Reproduce (updated)
Steps to reproduce the error:

1. Select and object
2. Activate fly-cam (hold RMB)
3. Press and hold any key used for transformation (G/R/S)
4. Release RMB
5. Held transformation key will begin it's own operation (e.g. if you held S key while releasing RMB, Scaling will begin)

To Reproduce (OLD and can be IGNORED)
Steps to reproduce the Grabbing behavior:

1. Select an object
2. Activate fly-cam (hold RMB)
3. Press G for Grab
4. The grabbing operation begins and object is moved with your camera when moving mouse.
5. Releasing the RMB ends the fly-cam mode, but the grab operation continues.

Steps to reproduce the Rotating behavior:

1. Select an object
2. Activate fly-cam (hold RMB)
3. Press and hold R for Rotate
4. Move camera around with mouse
5. Camera movement begins to stutter after a short while until you can't move the camera anymore
6. Release RMB
7. Rotation operation is activated and object can be rotated with R

You can instead just press (not hold) R button in step 3 and skip steps 4 and 5, just pressing R while in fly-cam mode will activate rotation operation anyway.

Steps to reproduce the Scaling behavior:

1. Select an object
2. Activate fly-cam (hold RMB)
3. Move back (S)
4. Stop fly-cam (release RMB) while moving back (don't release the S button yet)
5. Fly-cam movement will stop but since you're still holding the S button, the scaling operation will activate for the selected object

Expected behavior
Buttons used for transformations (G/R/S) aren't listened to by the engine for the transformation operations while fly-cam is active. In other words, pressing G/R/S doesn't being their respective transformation operations while or immediately after using fly-cam.

Screenshots

Grabbing problem:

grabbingbug.webm

Rotating problem:

rotatingbug.webm

It's OK at the beginning, but briefly stutters at the very end before stopping completely.
This is probably unrelated to Rotation operation and this problem was reported in another issue: #571
So consider stuttering probably unrelated. However, Rotation operation starting at the end is relevant to this issue.

The scaling problem:

scalingbug.webm

It might be a bit tricky to do:
RMB down -> hold S -> RMB up -> success

Platform

• Manjaro Linux
• Nvidia
• Wayland
• Kaiju version: commit 7fe23d2 (latest at the moment of writing this issue)
  Issue is still reproducible in a slightly different form on 78ade00

Additional context
Issue occurs no matter the amount of selected objects (tested with 1 and 2 objects).
Grabbing problem could be made into a feature I suppose, however at the current state it's clunky and hard to control.

[BrentFarris]

Nice find! Thank you for the detailed report, it helped me find an edge case for the fly camera. I believe this issue should now be resolved if I reproduced the cases correctly.

[4g10w]

Addressed this over discord, but also saying it here to document the progress:
Issue is still present, although grabbing bug now behaves differently. Not it acts like rotation bug: nothing happens at first, but if you hold G key, camera stutters, then stops. If you release RMB then, grab operations begins.
Rotation and Scaling bugs are still present for me.

[BrentFarris]

There might be something to this point because I'm not reproducing on Windows. I'll have to try it out on Linux. My best guess right now is that the key down event may be sending multiple times while holding the key down.

[4g10w]

On 78ade00 grabbing error no longer occurs.
However, if you hold G/R/S while releasing RMB, the respective transformation operation will begin.
Issue #571 suggests that perhaps R-operation has nothing to do with camera stuttering. I'll edit this issue to mention it.