Skip to content

Commit 03f9735

Browse files
pixelflipsdependabot[bot]QuintonJason
authored
Next Version Bump (#2169)
* chore(deps): bump @pine-ds/icons from 9.16.0 to 9.17.0 (#2166) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 9.16.0 to 9.17.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v9.16.0...v9.17.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-version: 9.17.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: use semantic focus-ring token across components (#2168) * style: replace hardcoded purple-600 with focus-ring token * style(breadcrumbs): add focus ring to progressbar variant * feat(hero): add shadow prop (#2170) * feat(hero): add shadow prop to React component and SCSS * feat(hero): add shadow prop to Rails component * docs(hero): add shadow prop documentation and preview examples * fix(hero): quote 050 shadow key in SCSS map and fix alt text hyphenation * fix(avatar): use semantic token (#2171) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
1 parent d719316 commit 03f9735

File tree

22 files changed

+122
-29
lines changed

22 files changed

+122
-29
lines changed

docs/app/views/examples/components/hero/_preview.html.erb

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,28 @@
142142
<% end %>
143143
<% end %>
144144

145+
<%= sage_component SageDivider, {} %>
146+
147+
<h2>Shadow</h2>
148+
<p>When the Hero has a shadow, a box-shadow will be applied to the Hero container.</p>
149+
150+
<%= sage_component SageHero, {
151+
title: "Learn with Kajabi in our live workshops",
152+
description: "Did you know we offer free workshops? Kajabi experts host live workshops every week on topics from marketing your products to building out your Kajabi account.",
153+
image: "hero-workshop-placeholder.jpg",
154+
alt_text: "Multi-layered illustration of UI elements and woman clasping her hands together in excitement",
155+
size: "small",
156+
borderless: true,
157+
shadow: "100",
158+
} do %>
159+
<% content_for :sage_hero_footer_actions do %>
160+
<%= sage_component SageButton, {
161+
value: "Learn more",
162+
style: "primary",
163+
} %>
164+
<% end %>
165+
<% end %>
166+
145167
<%# This is the modal triggered from various examples in this documentation %>
146168
<%= sage_component SageModal, { id: "cool-modal"} do %>
147169
<%= sage_component SageModalContent, {

docs/app/views/examples/components/hero/_props.html.erb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@
5858
<td><%= md('Boolean') %></td>
5959
<td><%= md('`false`') %></td>
6060
</tr>
61+
<tr>
62+
<td><%= md('`shadow`') %></td>
63+
<td><%= md('Sets the box-shadow on the Hero.') %></td>
64+
<td><%= md('String: ["none", "050", "100", "150", "200", "300", "400", "500"]') %></td>
65+
<td><%= md('`nil`') %></td>
66+
</tr>
6167
<tr>
6268
<td><%= md('`title`') %></td>
6369
<td><%= md('Sets the title for the component.') %></td>

docs/lib/sage_rails/app/sage_components/sage_hero.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ class SageHero < SageComponent
99
description: [:optional, NilClass, String],
1010
image: [:optional, NilClass, String],
1111
image_start: [:optional, NilClass, TrueClass],
12+
shadow: [:optional, NilClass, SageSchemas::HERO_SHADOW],
1213
size: [:optional, NilClass, SageSchemas::HERO_SIZE],
1314
title: [:optional, NilClass, String],
1415
title_tag: [:optional, NilClass, String],

docs/lib/sage_rails/app/sage_tokens/sage_schemas.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ module SageSchemas
2020

2121
HERO_SIZE = Set.new(SageTokens::HERO_SIZES)
2222

23+
HERO_SHADOW = Set.new(SageTokens::HERO_SHADOWS)
24+
2325
STATUSES = Set.new(SageTokens::STATUSES)
2426

2527
SPACER = {

docs/lib/sage_rails/app/sage_tokens/sage_tokens.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ def SageTokens.grid_templates
9797

9898
HERO_SIZES = ["small", "large"]
9999

100+
HERO_SHADOWS = ["none", "050", "100", "150", "200", "300", "400", "500"]
101+
100102
ICONS = [
101103
"access-key",
102104
"add",

docs/lib/sage_rails/app/views/sage_components/_sage_hero.html.erb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<%= "sage-hero--contained" if component.contained %>
2323
<%= "sage-hero--custom-background-color" if component.custom_background_color %>
2424
<%= "sage-hero--image-start" if component.image_start %>
25+
<%= "sage-hero--shadow-#{component.shadow}" if component.shadow.present? %>
2526
<%= component.generated_css_classes %>
2627
"
2728
data-js-hero

packages/sage-assets/lib/stylesheets/components/_alert.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ $-alert-text-colors: (
196196
}
197197

198198
&:focus-visible {
199-
@include sage-focus-outline--update-color(var(--pine-color-purple-600));
199+
@include sage-focus-outline--update-color(var(--pine-color-focus-ring));
200200
}
201201
}
202202

@@ -224,7 +224,7 @@ $-alert-text-colors: (
224224
}
225225

226226
&:focus-visible {
227-
@include sage-focus-outline--update-color(var(--pine-color-purple-600));
227+
@include sage-focus-outline--update-color(var(--pine-color-focus-ring));
228228
}
229229
}
230230

packages/sage-assets/lib/stylesheets/components/_avatar.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ $-avatar-max-size: calc(2 * var(--pine-dimension-800));
1010
$-avatar-ring-colors: (
1111
charcoal: (
1212
main: var(--pine-color-primary-hover),
13-
bg: var(--pine-color-grey-200)
13+
bg: var(--pine-color-background-inset)
1414
),
1515
grey: (
1616
main: var(--pine-color-primary-hover),
17-
bg: var(--pine-color-grey-200)
17+
bg: var(--pine-color-background-inset)
1818
),
1919
purple: (
2020
main: var(--pine-color-accent-hover),
@@ -30,7 +30,7 @@ $-avatar-ring-colors: (
3030
),
3131
orange: (
3232
main: var(--pine-color-brand),
33-
bg: var(--pine-color-grey-150)
33+
bg: var(--pine-color-background-muted)
3434
),
3535
red: (
3636
main: var(--pine-color-danger),
@@ -64,7 +64,7 @@ $-avatar-group-item-sizes: (
6464
width: $-avatar-min-size;
6565
height: $-avatar-min-size;
6666
border-radius: var(--pine-border-radius-full);
67-
background-color: var(--pine-color-grey-050);
67+
background-color: var(--pine-color-background-container-hover);
6868

6969
// Documentation-specific styles
7070
.sage-avatar-wrapper > & {

packages/sage-assets/lib/stylesheets/components/_breadcrumbs.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
$-breadcrumb-current-color: var(--pine-color-text);
88
$-breadcrumb-interactive-color: var(--pine-color-text);
9-
$-breadcrumb-outline-color: var(--pine-color-purple-600);
9+
$-breadcrumb-outline-color: var(--pine-color-focus-ring);
1010

1111
.sage-breadcrumbs {
1212
display: flex;
@@ -77,6 +77,7 @@ $-breadcrumb-outline-color: var(--pine-color-purple-600);
7777
.sage-breadcrumbs--progressbar & {
7878
position: relative;
7979
padding-block-end: sage-spacing(2xs);
80+
@include sage-focus-ring($-breadcrumb-outline-color);
8081

8182
&:active {
8283
color: $-breadcrumb-interactive-color;

packages/sage-assets/lib/stylesheets/components/_button.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ $-btn-base-styles: (
5151
color: var(--pine-color-text-primary),
5252
background-color: var(--pine-color-primary),
5353
border-color: var(--pine-color-primary),
54-
ring-color: var(--pine-color-purple-600),
54+
ring-color: var(--pine-color-focus-ring),
5555
),
5656
hover: (
5757
color: var(--pine-color-text-primary),
@@ -119,23 +119,23 @@ $-btn-subtle-styles: (
119119
hover: var(--pine-color-primary),
120120
hover-background: var(--pine-color-blue-150),
121121
focus: var(--pine-color-primary),
122-
focus-outline: var(--pine-color-purple-600),
122+
focus-outline: var(--pine-color-focus-ring),
123123
disabled: var(--pine-color-blue-300),
124124
),
125125
primary: (
126126
default: var(--pine-color-text),
127127
hover: var(--pine-color-primary),
128128
hover-background: var(--pine-color-primary-disabled),
129129
focus: var(--pine-color-primary),
130-
focus-outline: var(--pine-color-purple-600),
130+
focus-outline: var(--pine-color-focus-ring),
131131
disabled: var(--pine-color-text-tertiary),
132132
),
133133
secondary: (
134134
default: var(--pine-color-text),
135135
hover: var(--pine-color-primary),
136136
hover-background: var(--pine-color-primary-disabled),
137137
focus: var(--pine-color-primary),
138-
focus-outline: var(--pine-color-purple-600),
138+
focus-outline: var(--pine-color-focus-ring),
139139
disabled: var(--pine-color-text-tertiary),
140140
),
141141
danger: (

0 commit comments

Comments
 (0)