Fixes CAE-333 (redis#3290)

* Fixes CAE-333, which uncovered that the init method of the base
class did override the initialization of the socket_timeout parameter.

* Added missing blank lines

* Removed blank line

* Changed to quotes

---------

Co-authored-by: vladvildanov <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>

Author: 2 people

tests/test_connect.py

@@ -104,6 +104,23 @@ def test_tcp_ssl_tls12_custom_ciphers(tcp_address, ssl_ciphers):
     )
 
 
+"""
+Addresses bug CAE-333 which uncovered that the init method of the base
+class did override the initialization of the socket_timeout parameter.
+"""
+
+
+def test_unix_socket_with_timeout():
+    conn = UnixDomainSocketConnection(socket_timeout=1000)
+
+    # Check if the base class defaults were taken over.
+    assert conn.db == 0
+
+    # Verify if the timeout and the path is set correctly.
+    assert conn.socket_timeout == 1000
+    assert conn.path == ""
+
+
 @pytest.mark.ssl
 @pytest.mark.skipif(not ssl.HAS_TLSv1_3, reason="requires TLSv1.3")
 def test_tcp_ssl_version_mismatch(tcp_address):

valkey/connection.py

@@ -907,9 +907,9 @@ class UnixDomainSocketConnection(AbstractConnection):
     "Manages UDS communication to and from a Valkey server"
 
     def __init__(self, path="", socket_timeout=None, **kwargs):
+        super().__init__(**kwargs)
         self.path = path
         self.socket_timeout = socket_timeout
-        super().__init__(**kwargs)
 
     def repr_pieces(self):
         pieces = [("path", self.path), ("db", self.db)]