Skip to content

Commit 67eb77c

Browse files
authored
Merge pull request redis#69 from valkey-io/issue-46
Unify RESP3 and other tests workflows
2 parents 28ad27b + e5d43ee commit 67eb77c

File tree

1 file changed

+5
-49
lines changed

1 file changed

+5
-49
lines changed

.github/workflows/integration.yaml

Lines changed: 5 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ jobs:
6060
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
6161
test-type: ['standalone', 'cluster']
6262
connection-type: ['libvalkey', 'plain']
63+
protocol-version: ['2','3']
6364
env:
6465
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
65-
name: Python ${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
66+
name: Python ${{ matrix.python-version }} RESP${{ matrix.protocol-version }} ${{matrix.test-type}}-${{matrix.connection-type}} tests
6667
steps:
6768
- uses: actions/checkout@v4
6869
- uses: actions/setup-python@v5
@@ -79,15 +80,15 @@ jobs:
7980
fi
8081
invoke devenv
8182
sleep 10 # time to settle
82-
invoke ${{matrix.test-type}}-tests
83+
invoke ${{matrix.test-type}}-tests --protocol=${{ matrix.protocol-version }}
8384
if [[ "${{matrix.python-version}}" != pypy-* ]]; then
84-
invoke ${{matrix.test-type}}-tests --uvloop
85+
invoke ${{matrix.test-type}}-tests --uvloop --protocol=${{ matrix.protocol-version }}
8586
fi
8687
8788
- uses: actions/upload-artifact@v4
8889
if: success() || failure()
8990
with:
90-
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}
91+
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}-RESP${{ matrix.protocol-version }}
9192
path: '${{matrix.test-type}}*results.xml'
9293

9394
- name: Upload codecov coverage
@@ -97,51 +98,6 @@ jobs:
9798
token: ${{ secrets.CODECOV_TOKEN }}
9899

99100

100-
resp3_tests:
101-
runs-on: ubuntu-latest
102-
strategy:
103-
fail-fast: false
104-
matrix:
105-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
106-
test-type: ['standalone', 'cluster']
107-
connection-type: ['libvalkey', 'plain']
108-
env:
109-
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
110-
name: RESP3 [${{ matrix.python-version }} ${{matrix.test-type}}-${{matrix.connection-type}}]
111-
steps:
112-
- uses: actions/checkout@v4
113-
- uses: actions/setup-python@v5
114-
with:
115-
python-version: ${{ matrix.python-version }}
116-
cache: 'pip'
117-
- name: run tests
118-
run: |
119-
pip install -U setuptools wheel
120-
pip install -r requirements.txt
121-
pip install -r dev_requirements.txt
122-
if [ "${{matrix.connection-type}}" == "libvalkey" ]; then
123-
pip install "libvalkey>=4.0.0b1"
124-
fi
125-
invoke devenv
126-
sleep 10 # time to settle
127-
invoke ${{matrix.test-type}}-tests --protocol=3
128-
if [[ "${{matrix.python-version}}" != pypy-* ]]; then
129-
invoke ${{matrix.test-type}}-tests --uvloop --protocol=3
130-
fi
131-
132-
- uses: actions/upload-artifact@v4
133-
if: success() || failure()
134-
with:
135-
name: pytest-results-${{matrix.test-type}}-${{matrix.connection-type}}-${{matrix.python-version}}-resp3
136-
path: '${{matrix.test-type}}*results.xml'
137-
138-
- name: Upload codecov coverage
139-
uses: codecov/codecov-action@v4
140-
with:
141-
fail_ci_if_error: false
142-
token: ${{ secrets.CODECOV_TOKEN }}
143-
144-
145101
build_and_test_package:
146102
name: Validate building and installing the package
147103
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)