Skip to content

Commit 55459eb

Browse files
committed
use Gem::Version
1 parent f46768a commit 55459eb

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/sidekiq_adhoc_job.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def self.init
3434
strategy: @_config.strategy)
3535

3636
# Check if we're using Sidekiq 8+ which requires the new API
37-
if Sidekiq::VERSION >= '8.0'
37+
if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('8.0.0')
3838
Sidekiq::Web.configure do |config|
3939
config.register_extension(SidekiqAdhocJob::Web, name: 'Adhoc Jobs', tab: 'adhoc_jobs', index: 'adhoc-jobs')
4040
end

spec/sidekiq_adhoc_job_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def call(worker_name)
9090

9191
it 'loads worker files and adds web extension' do
9292
# Expect different behavior based on Sidekiq version
93-
if Sidekiq::VERSION >= '8.0'
93+
if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('8.0.0')
9494
expect(Sidekiq::Web).to receive(:configure)
9595
else
9696
expect(Sidekiq::Web).to receive(:register).with(SidekiqAdhocJob::Web)
@@ -130,7 +130,7 @@ def call(worker_name)
130130

131131
it 'loads worker files and adds web extension' do
132132
# Expect different behavior based on Sidekiq version
133-
if Sidekiq::VERSION >= '8.0'
133+
if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('8.0.0')
134134
expect(Sidekiq::Web).to receive(:configure)
135135
else
136136
expect(Sidekiq::Web).to receive(:register).with(SidekiqAdhocJob::Web)
@@ -152,7 +152,7 @@ def call(worker_name)
152152

153153
it 'loads worker files and adds web extension' do
154154
# Expect different behavior based on Sidekiq version
155-
if Sidekiq::VERSION >= '8.0'
155+
if Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new('8.0.0')
156156
expect(Sidekiq::Web).to receive(:configure)
157157
else
158158
expect(Sidekiq::Web).to receive(:register).with(SidekiqAdhocJob::Web)

0 commit comments

Comments
 (0)