Merge pull request #9 from Kaligo/fix/nil-method-owner

Fix crash when worker does not define #perform method

Author: kidlab

CHANGELOG.md

@@ -1,4 +1,8 @@
 # Change Log
+
+## 2.4.1
+- Fix crash when worker does not define #perform method
+
 ## 2.4.0
 - Switch rspec to test for mutiple sidekiq version
 - Support both sidekiq 8 and 7

lib/sidekiq_adhoc_job/utils/class_inspector.rb

@@ -48,7 +48,7 @@ def has_rest_parameter?(method_name)
       end
 
       def klass_method(method)
-        return method if method.owner == klass_name
+        return method if method.owner == klass_name || !method.super_method
 
         klass_method(method.super_method)
       end

lib/sidekiq_adhoc_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SidekiqAdhocJob
-  VERSION = '2.4.0'
+  VERSION = '2.4.1'
 end

spec/sidekiq_adhoc_job/utils/class_inspector_spec.rb

@@ -9,12 +9,12 @@
 
   describe '#parameters' do
     it do
-      expect(inspector.parameters(:perform)).to eq({
-                                                     key: [:dryrun],
-                                                     keyreq: [:type],
-                                                     opt: %i[retry_job retries interval name options],
-                                                     req: %i[id overwrite]
-                                                   })
+      expect(inspector.parameters(:perform)).to eq(
+        key: [:dryrun],
+        keyreq: [:type],
+        opt: %i[retry_job retries interval name options],
+        req: %i[id overwrite]
+      )
     end
   end
 
@@ -23,10 +23,10 @@
 
     describe '#parameters' do
       it 'returns the parameters of the original method' do
-        expect(inspector.parameters(:perform)).to eq({
-                                                       opt: %i[retry_job retries interval],
-                                                       req: %i[id overwrite]
-                                                     })
+        expect(inspector.parameters(:perform)).to eq(
+          opt: %i[retry_job retries interval],
+          req: %i[id overwrite]
+        )
       end
     end
   end
@@ -36,10 +36,29 @@
 
     describe '#parameters' do
       it 'returns the parameters of the method on the target class' do
-        expect(inspector.parameters(:perform)).to eq({
-                                                       opt: %i[retry_job retries interval],
-                                                       req: %i[id overwrite]
-                                                     })
+        expect(inspector.parameters(:perform)).to eq(
+          opt: %i[retry_job retries interval],
+          req: %i[id overwrite]
+        )
+      end
+    end
+  end
+
+  context "with an inherited class without redefining method" do
+    before do
+      stub_const("TempWorker", Class.new(SidekiqAdhocJob::Test::DummyWorker))
+    end
+
+    let(:klass) { TempWorker }
+
+    describe "#parameters" do
+      it "returns the parameters of the parent method" do
+        expect(inspector.parameters(:perform)).to eq(
+          key: [:dryrun],
+          keyreq: [:type],
+          opt: [:retry_job, :retries, :interval, :name, :options],
+          req: [:id, :overwrite]
+        )
       end
     end
   end