-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Description
Description
While performing FG reconstruction, I encountered an issue that should be addressed to improve usability and clarity in the codebase:
Ambiguity in layer_map regarding reference_net
- The current
layer_mapfunction does not explicitly indicate thenorm1andnorm2layers forreference_net, making it harder to understand at a glance. - Although these mappings can be found in the source code, explicitly listing them in
layer_mapwill improve readability. - These layers are used for FG reconstruction.
Proposed Changes
Improve layer_map readability by explicitly listing norm1 and norm2 for reference_net
Modify the reference_net entry in layer_map:
'reference_net': {
'conv1': 'features[0]',
'relu1': 'features[1]',
'norm1': 'features[3]', # Explicitly added
'conv2': 'features[4]',
'relu2': 'features[5]',
'norm2': 'features[7]', # Explicitly added
'conv3': 'features[8]',
'relu3': 'features[9]',
'conv4': 'features[10]',
'relu4': 'features[11]',
'conv5': 'features[12]',
'relu5': 'features[13]',
'fc6': 'classifier[1]',
'relu6': 'classifier[2]',
'fc7': 'classifier[4]',
'relu7': 'classifier[5]',
'fc8': 'classifier[6]',
}Expected Benefits
- The
layer_mapwill be more intuitive, reducing confusion when working withreference_net, especially for new contributors.
Would appreciate any feedback on this!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels