EditorWindow: avoid creating empty new files

This change adds a sort of "phantom mode" where a filename is passed on the
command line that doesn't exist yet but the editor treats it as an existing
file.

Generic error checking was added to SaveFile() to catch other types of errors.
For the case of phantom mode, this includes attempting trying to run something
like `Koder /system/foo.txt` and then trying to save the file to a read-only
location.

Author: augiedoggie

locales/en.catkeys

@@ -1,4 +1,4 @@
-1	English	x-vnd.KapiX-Koder	2781821189
+1	English	x-vnd.KapiX-Koder	3292494141
 Something wrong has happened while opening the configuration file. Your personal settings will not be %s%.	Preferences		Something wrong has happened while opening the configuration file. Your personal settings will not be %s%.
 Access denied	EditorWindow		Access denied
 Line endings	EditorWindow		Line endings
@@ -36,6 +36,7 @@ There is not enough memory available to %s% the configuration file. Try closing
 Folds	AppPreferencesWindow		Folds
 Visual	AppPreferencesWindow		Visual
 Wrap around	FindWindow		Wrap around
+Save error	EditorWindow		Save error
 Highlight current line	AppPreferencesWindow		Highlight current line
 Left margin	AppPreferencesWindow		Left margin
 Go to line…	EditorWindow		Go to line…
@@ -162,6 +163,7 @@ Highlight trailing whitespace	AppPreferencesWindow		Highlight trailing whitespac
 Up to the next/previous non-empty line	AppPreferencesWindow		Up to the next/previous non-empty line
 Show indentation guides	AppPreferencesWindow		Show indentation guides
 Koder preferences	AppPreferencesWindow		Koder preferences
+An error occurred while attempting to save the file.	EditorWindow		An error occurred while attempting to save the file.
 Don't save	QuitAlert		Don't save
 Replace	FindWindow		Replace
 [read-only]	EditorWindow		[read-only]

src/editor/EditorWindow.cpp

@@ -294,19 +294,20 @@ EditorWindow::OpenFile(const entry_ref* ref, Sci_Position line, Sci_Position col
 	}
 
 	BEntry entry(ref);
-	uint32 openMode = B_READ_ONLY;
-	if(!entry.Exists()) {
-		// TODO: alert/phantom mode?
-		openMode |= B_CREATE_FILE;
+
+	File file(&entry, B_READ_ONLY);
+	if(entry.Exists()) {
+		fReadOnly = !File::CanWrite(&file);
+		file.Monitor(true, this);
+		file.GetModificationTime(&fOpenedFileModificationTime);
+		fEditor->SetText(file.Read().data());
+	} else {
+		// TODO check if we have directory permissions to create a new file?
+		fReadOnly = false;
 	}
 
-	File file(&entry, openMode);
-	file.Monitor(true, this);
-	file.GetModificationTime(&fOpenedFileModificationTime);
 	fModifiedOutside = false;
 
-	fEditor->SetText(file.Read().data());
-
 	fEditor->SendMessage(SCI_SETSAVEPOINT);
 	fEditor->SendMessage(SCI_EMPTYUNDOBUFFER);
 
@@ -325,7 +326,6 @@ EditorWindow::OpenFile(const entry_ref* ref, Sci_Position line, Sci_Position col
 	entry.GetName(name);
 	_SetLanguageByFilename(name);
 
-	fReadOnly = !File::CanWrite(&file);
 	fEditor->SetReadOnly(fReadOnly);
 	fEditor->SetRef(*ref);
 
@@ -381,10 +381,15 @@ EditorWindow::SaveFile(entry_ref* ref)
 
 	// TODO error checking
 	File file(path.c_str(), B_WRITE_ONLY | B_CREATE_FILE | B_ERASE_FILE);
-	if(file.InitCheck() == B_PERMISSION_DENIED) {
+	status_t result = file.InitCheck();
+	if(result == B_PERMISSION_DENIED) {
 		OKAlert(B_TRANSLATE("Access denied"), B_TRANSLATE("You don't have "
 			"sufficient permissions to edit this file."), B_STOP_ALERT);
 		return;
+	} else if(result != B_OK) {
+		OKAlert(B_TRANSLATE("Save error"), B_TRANSLATE("An error occurred "
+			"while attempting to save the file."), B_STOP_ALERT);
+		return;
 	}
 	file.Monitor(false, this);