don't build tests by default

Author: scivision

.github/workflows/ci.yml

@@ -7,6 +7,13 @@ on:
       - "**.cmake"
       - "**/CMakeLists.txt"
       - ".github/workflows/ci.yml"
+  workflow_dispatch:
+
+# avoid wasted runs
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 
 jobs:
 
@@ -20,15 +27,16 @@ jobs:
     timeout-minutes: 5
 
     steps:
-    - uses: actions/checkout@v4
+    - &checkout
+      uses: actions/checkout@v4
 
-    - run: cmake --workflow --preset default
+    - run: cmake --workflow default
 
   windows_msvc:
     runs-on: windows-latest
     timeout-minutes: 5
 
     steps:
-    - uses: actions/checkout@v4
+    - *checkout
 
-    - run: cmake --workflow --preset msvc
+    - run: cmake --workflow release

CMakeLists.txt

@@ -1,14 +1,20 @@
-cmake_minimum_required(VERSION 3.14...3.28)
+cmake_minimum_required(VERSION 3.16...4.1)
+
+if(NOT CMAKE_BUILD_TYPE AND NOT DEFINED ENV{CMAKE_BUILD_TYPE})
+  set(CMAKE_BUILD_TYPE Release CACHE STRING "Build type")
+endif()
 
 project(GKlib LANGUAGES C
 VERSION 1.0.0
 )
 
 enable_testing()
 
-option(BUILD_TESTING "Build tests" ON)
+include(GNUInstallDirs)
+
+option(BUILD_TESTING "Build tests")
 
-option(BUILD_SHARED_LIBS "Build shared libraries (.dll/.so) instead of static ones (.lib/.a)" OFF)
+option(BUILD_SHARED_LIBS "Build shared libraries (.dll/.so) instead of static ones (.lib/.a)")
 
 if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT AND GKlib_IS_TOP_LEVEL)
   set(CMAKE_INSTALL_PREFIX "${PROJECT_BINARY_DIR}/local" CACHE PATH "install prefix" FORCE)
@@ -34,7 +40,7 @@ error.c		gk_util.c	itemsets.c	rw.c		tokenizer.c)
 add_library(GKlib ${GKlib_sources} ${win32_sources})
 target_include_directories(GKlib PUBLIC
 $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
-$<INSTALL_INTERFACE:include>
+$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 )
 target_link_libraries(GKlib PRIVATE
 $<$<BOOL:${UNIX}>:m>

CMakePresets.json

@@ -6,14 +6,7 @@
   "name": "default",
   "binaryDir": "${sourceDir}/build",
   "cacheVariables": {
-    "CMAKE_COMPILE_WARNING_AS_ERROR": true
-  }
-},
-{
-  "name": "msvc", "inherits": "default",
-  "generator": "Visual Studio 17 2022",
-  "cacheVariables": {
-    "CMAKE_COMPILE_WARNING_AS_ERROR": false
+    "BUILD_TESTING": true
   }
 }
 ],
@@ -26,11 +19,6 @@
     "name": "release",
     "configurePreset": "default",
     "configuration": "Release"
-  },
-  {
-    "name": "msvc-debug",
-    "configurePreset": "msvc",
-    "configuration": "Debug"
   }
 ],
 "testPresets": [
@@ -51,11 +39,6 @@
 {
   "name": "release", "inherits": "default",
   "configuration": "Release"
-},
-{
-  "name": "msvc-debug", "inherits": "default",
-  "configurePreset": "msvc",
-  "configuration": "Debug"
 }
 ],
 "workflowPresets": [
@@ -76,23 +59,6 @@
       }
     ]
   },
-  {
-    "name": "msvc",
-    "steps": [
-      {
-        "type": "configure",
-        "name": "msvc"
-      },
-      {
-        "type": "build",
-        "name": "msvc-debug"
-      },
-      {
-        "type": "test",
-        "name": "msvc-debug"
-      }
-    ]
-  },
   {
     "name": "release",
     "steps": [

cmake/config.cmake.in

@@ -2,8 +2,4 @@
 
 include(${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@-targets.cmake)
 
-set(ffilesystem_shaky @ffilesystem_shaky@)
-
-target_link_libraries(metis::metis INTERFACE GKlib)
-
 check_required_components(@PROJECT_NAME@)