Refs #38856 - halt manual composite publish if children are publishing

Author: ianballou

.github/workflows/ruby.yml

@@ -18,7 +18,7 @@ jobs:
     uses: theforeman/actions/.github/workflows/rubocop.yml@v0
     with:
       command: bundle exec rubocop --parallel --format github
-      ruby-version: '3.0'
+      ruby: '3.0'
 
   test:
     name: Ruby
@@ -27,7 +27,6 @@ jobs:
     with:
       plugin: katello
       foreman_version: develop # set to the Foreman release branch after branching :)
-      ruby-version: '3.0'
 
   angular:
     name: Angular ${{ matrix.engine }} - NodeJS ${{ matrix.node }}

app/models/katello/content_view.rb

@@ -663,6 +663,7 @@ def check_ready_to_publish!(importing: false, syncable: false)
         check_docker_repository_names!([organization.library])
         check_orphaned_content_facets!(environments: self.environments)
         check_scheduled_publish!
+        check_component_publishes!
       end
 
       true
@@ -686,6 +687,14 @@ def check_scheduled_publish!
       end
     end
 
+    def check_component_publishes!
+      return unless composite?
+
+      if ::Katello::ContentViewManager.running_component_publish_tasks(self).any?
+        fail ::Katello::Errors::ConflictException, _("Cannot publish composite content view while its content views are being published. Please wait for component publishes to complete.")
+      end
+    end
+
     def check_docker_repository_names!(environments)
       environments.each do |environment|
         repositories = []

test/models/content_view_test.rb

@@ -865,5 +865,26 @@ def test_check_scheduled_publish_raises_when_scheduled_publish_exists
 
       assert_match(/publish is already scheduled/, error.message)
     end
+
+    def test_check_component_publishes_raises_when_component_publishes_running
+      composite_cv = katello_content_views(:composite_view)
+      running_task = mock('task')
+
+      Katello::ContentViewManager.stubs(:running_component_publish_tasks).with(composite_cv).returns([running_task])
+
+      error = assert_raises(Katello::Errors::ConflictException) do
+        composite_cv.check_component_publishes!
+      end
+
+      assert_match(/component content views are being published/, error.message)
+    end
+
+    def test_check_component_publishes_passes_when_no_component_publishes
+      composite_cv = katello_content_views(:composite_view)
+
+      Katello::ContentViewManager.stubs(:running_component_publish_tasks).with(composite_cv).returns([])
+
+      composite_cv.check_component_publishes!
+    end
   end
 end