Fixes #39122 - Don't allow separate params to reset multiCV hosts (#11662)

* Fixes #39122 - Don't allow separate params to reset multiCV hosts

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Refs #39122 - use fixtures

Co-authored-by: Quinn James <35753203+qcjames53@users.noreply.github.com>

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Quinn James <35753203+qcjames53@users.noreply.github.com>

Author: 3 people

app/controllers/katello/api/v2/activation_keys_controller.rb

@@ -23,9 +23,9 @@ class Api::V2::ActivationKeysController < Api::V2::ApiController  # rubocop:disa
       param :purpose_usage, String, :desc => N_("Sets the system purpose usage")
       param :purpose_role, String, :desc => N_("Sets the system purpose usage")
 
-      param :environment, Hash, :desc => N_("Hash containing the Id of the single lifecycle environment to be associated with the activation key."), deprecated: true
-      param :content_view_id, Integer, :desc => N_("Id of the single content view to be associated with the activation key."), :allow_nil => true
-      param :environment_id, Integer, :desc => N_("Id of the single lifecycle environment to be associated with the activation key."), :allow_nil => true
+      param :environment, Hash, :deprecated => true, :desc => N_("Hash containing the Id of the single lifecycle environment to be associated with the activation key.")
+      param :content_view_id, Integer, :deprecated => true, :desc => N_("Id of the single content view to be associated with the activation key."), :allow_nil => true
+      param :environment_id, Integer, :deprecated => true, :desc => N_("Id of the single lifecycle environment to be associated with the activation key."), :allow_nil => true
       param :content_view_environments, Array, :desc => N_("Comma-separated list of content view environment labels to be associated with the activation key,"\
                                               " in the format of 'lifecycle_environment_label/content_view_label'."\
                                               " Ignored if content_view_environment_ids is specified, or if content_view_id and lifecycle_environment_id are specified."\

app/controllers/katello/api/v2/host_contents_controller.rb

@@ -1,8 +1,8 @@
 module Katello
   class Api::V2::HostContentsController < Katello::Api::V2::ApiController
     def_param_group :content_facet_attributes do
-      param :content_view_id, Integer, :desc => N_("Id of the single content view to be associated with the host.")
-      param :lifecycle_environment_id, Integer, :desc => N_("Id of the single lifecycle environment to be associated with the host.")
+      param :content_view_id, Integer, :deprecated => true, :desc => N_("Id of the single content view to be associated with the host. Ignored for multi-environment hosts.")
+      param :lifecycle_environment_id, Integer, :deprecated => true, :desc => N_("Id of the single lifecycle environment to be associated with the host. Ignored for multi-environment hosts.")
       param :content_view_environments, Array, :desc => N_("Comma-separated list of content view environment labels to be associated with the host,"\
                                               " in the format of 'lifecycle_environment_label/content_view_label'."\
                                               " Ignored if content_view_environment_ids is specified, or if content_view_id and lifecycle_environment_id are specified."\

app/models/katello/concerns/host_managed_extensions.rb

@@ -18,6 +18,11 @@ def check_cve_attributes(attrs)
             # them below in add_back_cve_errors.
             @pending_cve_attrs = { content_view_id: cv_id, lifecycle_environment_id: lce_id }
             if cv_id && lce_id
+              if content_facet&.multi_content_view_environment?
+                Rails.logger.warn "content_view_id and lifecycle_environment_id cannot be used to reassign multi-environment host '#{name}'. Use content_view_environment_ids instead"
+                @pending_cve_attrs = {}
+                return
+              end
               cve = content_facet&.assign_single_environment(content_view_id: cv_id, lifecycle_environment_id: lce_id)
               Rails.logger.warn "Couldn't assign content view environment; host has no content facet" if cve.blank?
               @pending_cve_attrs = {}

test/models/concerns/host_managed_extensions_test.rb

@@ -207,6 +207,29 @@ def test_yum_or_yum_transient
   end
 
   class HostManagedExtensionsUpdateTest < HostManagedExtensionsTestBase
+    def test_multi_environment_host_ignores_single_params
+      ::Host::Managed.any_instance.stubs(:update_candlepin_associations)
+      host = FactoryBot.create(:host, :with_content, :with_subscription, :content_view => @library_view, :lifecycle_environment => @library)
+
+      # Add a second content view environment to make this a multi-environment host
+      library_dev_view = katello_content_views(:library_dev_view)
+      dev_env = katello_environments(:dev)
+      second_cve = ContentViewEnvironment.find_by(content_view: library_dev_view, environment: dev_env)
+      original_cves = host.content_facet.content_view_environments.to_a
+      host.content_facet.content_view_environments = original_cves + [second_cve]
+      host.save!
+      assert host.content_facet.multi_content_view_environment?
+
+      # Try to update with single params
+      host_attrs = host.attributes.deep_clone
+      host_attrs[:content_facet_attributes] = {content_view_id: @view.id, lifecycle_environment_id: @dev.id}
+      Rails.logger.expects(:warn).with("content_view_id and lifecycle_environment_id cannot be used to reassign multi-environment host '#{host.name}'. Use content_view_environment_ids instead")
+      host.check_cve_attributes(host_attrs)
+
+      # Multi-environment host should ignore single params and keep original environments
+      assert_equal original_cves + [second_cve], host.content_facet.content_view_environments
+    end
+
     def test_update
       host = FactoryBot.create(:host, :with_content, :with_subscription, :content_view => @library_view, :lifecycle_environment => @library)
       host.content_facet.expects(:save!)