Refs #38856 - fail CCV publish if already scheduled

Author: ianballou

app/models/katello/content_view.rb

@@ -662,6 +662,7 @@ def check_ready_to_publish!(importing: false, syncable: false)
         check_composite_action_allowed!(organization.library)
         check_docker_repository_names!([organization.library])
         check_orphaned_content_facets!(environments: self.environments)
+        check_scheduled_publish!
       end
 
       true
@@ -677,6 +678,14 @@ def check_repositories_blocking_publish!
       end
     end
 
+    def check_scheduled_publish!
+      return unless composite?
+
+      if ::Katello::ContentViewManager.scheduled_composite_publish?(self)
+        fail ::Katello::Errors::ConflictException, _("A publish is already scheduled for this content view. Please wait for the scheduled publish to complete.")
+      end
+    end
+
     def check_docker_repository_names!(environments)
       environments.each do |environment|
         repositories = []

test/factories/foreman_task.rb

@@ -7,7 +7,7 @@
     result { 'success' }
     sequence(:started_at) { |n| "2016-#{(n / 30) + 1}-#{(n % 30) + 1} 11:15:00" }
     after(:build) do |task|
-      task.ended_at = task.started_at.change(:sec => 32)
+      task.ended_at = task.started_at.change(:sec => 32) if task.started_at
     end
 
     trait :running do
@@ -21,6 +21,13 @@
       result { 'error' }
       ended_at { nil }
     end
+
+    trait :scheduled do
+      state { 'scheduled' }
+      result { 'pending' }
+      started_at { nil }
+      ended_at { nil }
+    end
   end
 
   factory :dynflow_task, :parent => :foreman_task, :class => ForemanTasks::Task::DynflowTask do

test/models/content_view_test.rb

@@ -853,5 +853,25 @@ def test_ignore_generated
       ignore_generated_include_library = Katello::ContentView.ignore_generated(include_library_generated: true).count
       assert_equal (ignore_generated - ignore_generated_include_library), 2
     end
+
+    def test_check_scheduled_publish_raises_when_scheduled_publish_exists
+      composite_cv = katello_content_views(:composite_view)
+
+      # Create a scheduled publish task for the composite CV
+      task = FactoryBot.create(:dynflow_task, :scheduled,
+                                label: 'Actions::Katello::ContentView::Publish',
+                                external_id: 'test-scheduled-publish-check-123')
+
+      # Mock the delayed plan to return our composite CV as first arg
+      delayed_plan = mock('delayed_plan')
+      delayed_plan.stubs(:args).returns([composite_cv])
+      ForemanTasks.dynflow.world.persistence.stubs(:load_delayed_plan).with(task.external_id).returns(delayed_plan)
+
+      error = assert_raises(Katello::Errors::ConflictException) do
+        composite_cv.check_scheduled_publish!
+      end
+
+      assert_match(/publish is already scheduled/, error.message)
+    end
   end
 end