Skip to content

Commit 344ece7

Browse files
committed
Merge branch '293-fix-ipv6' into develop
2 parents 1ca8db8 + 184f3f0 commit 344ece7

File tree

4 files changed

+35
-2
lines changed

4 files changed

+35
-2
lines changed

src/Kathara/manager/docker/DockerMachine.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ def create(self, machine: Machine) -> None:
252252
sysctl_parameters["net.ipv6.icmp.ratelimit"] = 0
253253
sysctl_parameters["net.ipv6.conf.default.disable_ipv6"] = 0
254254
sysctl_parameters["net.ipv6.conf.all.disable_ipv6"] = 0
255+
else:
256+
sysctl_parameters["net.ipv6.conf.default.disable_ipv6"] = 1
257+
sysctl_parameters["net.ipv6.conf.all.disable_ipv6"] = 1
258+
sysctl_parameters["net.ipv6.conf.default.forwarding"] = 0
259+
sysctl_parameters["net.ipv6.conf.all.forwarding"] = 0
255260

256261
# Merge machine sysctls
257262
sysctl_parameters = {**sysctl_parameters, **machine.meta['sysctls'], **sysctl_first_interface}

src/Kathara/manager/kubernetes/KubernetesMachine.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,11 @@ def create(self, machine: Machine) -> None:
304304
sysctl_parameters["net.ipv6.icmp.ratelimit"] = 0
305305
sysctl_parameters["net.ipv6.conf.default.disable_ipv6"] = 0
306306
sysctl_parameters["net.ipv6.conf.all.disable_ipv6"] = 0
307+
else:
308+
sysctl_parameters["net.ipv6.conf.default.disable_ipv6"] = 1
309+
sysctl_parameters["net.ipv6.conf.all.disable_ipv6"] = 1
310+
sysctl_parameters["net.ipv6.conf.default.forwarding"] = 0
311+
sysctl_parameters["net.ipv6.conf.all.forwarding"] = 0
307312

308313
# Merge machine sysctls
309314
machine.meta['sysctls'] = {**sysctl_parameters, **machine.meta['sysctls']}

tests/manager/docker/docker_machine_test.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,11 @@ def test_create(mock_get_current_user_name, mock_setting_get_instance, mock_copy
101101
'net.ipv4.conf.default.rp_filter': 0,
102102
'net.ipv4.conf.lo.rp_filter': 0,
103103
'net.ipv4.ip_forward': 1,
104-
'net.ipv4.icmp_ratelimit': 0
104+
'net.ipv4.icmp_ratelimit': 0,
105+
'net.ipv6.conf.default.disable_ipv6': 1,
106+
'net.ipv6.conf.all.disable_ipv6': 1,
107+
'net.ipv6.conf.default.forwarding': 0,
108+
'net.ipv6.conf.all.forwarding': 0,
105109
},
106110
environment={},
107111
mem_limit='64m',
@@ -276,6 +280,10 @@ def __init__(self, name):
276280
'net.ipv4.conf.lo.rp_filter': 0,
277281
'net.ipv4.ip_forward': 1,
278282
'net.ipv4.icmp_ratelimit': 0,
283+
'net.ipv6.conf.default.disable_ipv6': 1,
284+
'net.ipv6.conf.all.disable_ipv6': 1,
285+
'net.ipv6.conf.default.forwarding': 0,
286+
'net.ipv6.conf.all.forwarding': 0,
279287
},
280288
environment={},
281289
mem_limit='64m',
@@ -340,6 +348,10 @@ def __init__(self, name):
340348
'net.ipv4.conf.eth0.rp_filter': 0,
341349
'net.ipv4.ip_forward': 1,
342350
'net.ipv4.icmp_ratelimit': 0,
351+
'net.ipv6.conf.default.disable_ipv6': 1,
352+
'net.ipv6.conf.all.disable_ipv6': 1,
353+
'net.ipv6.conf.default.forwarding': 0,
354+
'net.ipv6.conf.all.forwarding': 0,
343355
},
344356
environment={},
345357
mem_limit='64m',
@@ -411,6 +423,10 @@ def __init__(self, name):
411423
'net.ipv4.conf.lo.rp_filter': 0,
412424
'net.ipv4.ip_forward': 1,
413425
'net.ipv4.icmp_ratelimit': 0,
426+
'net.ipv6.conf.default.disable_ipv6': 1,
427+
'net.ipv6.conf.all.disable_ipv6': 1,
428+
'net.ipv6.conf.default.forwarding': 0,
429+
'net.ipv6.conf.all.forwarding': 0,
414430
},
415431
environment={},
416432
mem_limit='64m',
@@ -483,6 +499,10 @@ def __init__(self, name):
483499
'net.ipv4.conf.eth0.rp_filter': 0,
484500
'net.ipv4.ip_forward': 1,
485501
'net.ipv4.icmp_ratelimit': 0,
502+
'net.ipv6.conf.default.disable_ipv6': 1,
503+
'net.ipv6.conf.all.disable_ipv6': 1,
504+
'net.ipv6.conf.default.forwarding': 0,
505+
'net.ipv6.conf.all.forwarding': 0,
486506
},
487507
environment={},
488508
mem_limit='64m',

tests/manager/kubernetes/kubernetes_machine_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ def kubernetes_device_definition():
5252

5353
sysctl_commands = "sysctl -w -q net.ipv4.conf.all.rp_filter=0; sysctl -w -q net.ipv4.conf.default.rp_filter=0; " \
5454
"sysctl -w -q net.ipv4.conf.lo.rp_filter=0; sysctl -w -q net.ipv4.ip_forward=1; " \
55-
"sysctl -w -q net.ipv4.icmp_ratelimit=0"
55+
"sysctl -w -q net.ipv4.icmp_ratelimit=0; sysctl -w -q net.ipv6.conf.default.disable_ipv6=1; " \
56+
"sysctl -w -q net.ipv6.conf.all.disable_ipv6=1; sysctl -w -q net.ipv6.conf.default.forwarding=0; " \
57+
"sysctl -w -q net.ipv6.conf.all.forwarding=0"
58+
5659
startup_commands_string = "; ".join(STARTUP_COMMANDS) \
5760
.format(machine_name="test_device", sysctl_commands=sysctl_commands, machine_commands="ls")
5861

0 commit comments

Comments
 (0)