Version 0.1.13

Author: tcaiazzi

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "kathara_lab_checker"
-version = "0.1.12"
+version = "0.1.13"
 description = "Tool to automatically check Kathará network scenarios based on a configuration file."
 readme = "README.md"
 requires-python = ">=3.11"

src/kathara_lab_checker/__main__.py

@@ -23,7 +23,7 @@
 from .foundation.checks.CheckFactory import CheckFactory
 from .foundation.model.CheckResult import CheckResult
 
-VERSION = "0.1.12"
+VERSION = "0.1.13"
 CURRENT_LAB: Optional[Lab] = None
 
 

src/kathara_lab_checker/checks/BridgeCheck.py

@@ -161,13 +161,9 @@ def check_vlan_pvid(self, device_name: str, interface_name: str, interface_pvid:
             reason = f"No pvid configured on `{interface_name}` of `{device_name}`"
             return FailedCheck(self.description, reason)
 
-    def run(self, configuration: dict[str, Any]) -> list[CheckResult]:
+    def run(self, devices_to_bridge_configuration: dict[str, Any]) -> list[CheckResult]:
         results = []
 
-        if 'bridges' not in configuration:
-            return results
-
-        devices_to_bridge_configuration = configuration["bridges"]
         for device_name, bridges_configuration in devices_to_bridge_configuration.items():
             self.logger.info(f"Checking bridges configuration on `{device_name}`...")
             try:
@@ -256,8 +252,8 @@ def run(self, configuration: dict[str, Any]) -> list[CheckResult]:
         return results
 
     def run_from_configuration(self, configuration: dict) -> list[CheckResult]:
-        self.logger.info("Verifying bridges configuration inside devices...")
         if key_exists(["test", "bridges"], configuration):
+            self.logger.info("Verifying bridges configuration inside devices...")
             return self.run(configuration["test"]["bridges"])
         else:
             return []

src/kathara_lab_checker/checks/protocols/bgp/BGPNeighborCheck.py

@@ -1,6 +1,6 @@
 import json
 
-from Kathara.exceptions import MachineNotRunningError
+from Kathara.exceptions import MachineNotRunningError, MachineBinaryError
 from Kathara.model.Lab import Lab
 
 from ....foundation.checks.AbstractCheck import AbstractCheck
@@ -28,6 +28,12 @@ def check(self, device_name: str, neighbors: list) -> list[CheckResult]:
         except MachineNotRunningError as e:
             results.append(FailedCheck(f"Checking {device_name} BGP neighbors", str(e)))
             return results
+        except MachineBinaryError as e:
+            results.append(FailedCheck(f"Checking {device_name} BGP neighbors", str(e)))
+            return results
+        except Exception as e:
+            results.append(FailedCheck(f"Checking {device_name} BGP neighbors", str(e)))
+            return results
 
         output = stdout.decode("utf-8") if stdout else None