Blank Approval Window

[corrigenda-admin]

Hi,

We have a new issue appeared that when we click "To approve" the screen is now completely blank, doesnt show any history or any users.

We can click "Approved Weeks Report" and it shows but the overview screen doesnt show any users?

There is nothing F12 Console logs and nothing in the Kimai logs. We are on the latest version of Kimai and the Latest build of the Approval Bundle?

Not sure whats happening or what i can provide to help diagnose?

[corrigenda-admin]

We have resolved this issue.

it was relating to it querying the full database and filtering it on the page, as we have over 250 people working from it and have been for many months, it was hitting a limit on the visual display.

We have added a new method and new helper method in the ApprovalRepository which filters the query more at a database level before loading it on the page which helps reduce the issues.

We then updated the WeekReportController.php to use the new method:

findAllWeek($users) → findPendingApprovals($users)

Fixes - ApprovalRepository.txt

[KatjaGlassConsulting]

Thanks for investigating and finding the issue including also the fix. I will likely have a closer look and implement this in December. For this I will reopen the issue, so it can be solved for everyone. :)

[corrigenda-admin]

Perfect, thank you!

The only other issue we came across on the "to approve" page is that when we had users that submitted for approval, then it was denied and resubmitted, the overview page wasnt always pulling the latest status of the approval.

[KatjaGlassConsulting]

Hi @corrigenda-admin ,

can you please check the new release 2.3? Luis Antonio Galvez has implemented changes (see PR here) - there is now a new option to "hide approved approvals" -> with this the display should already by default show less. If the origin issue is still available - so the fix-file should still be applied, please let me know.

Please also consider a direct Pull Request. Can you also check the second issue whether it's still available? I guess so? If so could you please open a second issue for this?

Thanks :)