feat: enhance item background management to support disabling backgrounds

Author: KdGaming0

src/main/java/com/github/kd_gaming1/packcore/integration/itembackground/ItemBackgroundManager.java

@@ -36,14 +36,15 @@ public static boolean applyItemBackgroundFromWizard() {
             return false;
         }
 
+        // mapper returns null for "none" meaning "disable backgrounds"
         String style = mapToSkyblockerStyle(itemBackground);
         return applyItemBackgroundStyle(style);
     }
 
     /**
-     * Applies a specific item background style.
+     * Applies a specific item background style or disables backgrounds when style is null.
      *
-     * @param style the style enum name (CIRCULAR, SQUARE, or NONE)
+     * @param style the style enum name (CIRCULAR, SQUARE) or null to disable rarity backgrounds
      * @return true if successfully applied, false otherwise
      */
     private static boolean applyItemBackgroundStyle(String style) {
@@ -54,7 +55,7 @@ private static boolean applyItemBackgroundStyle(String style) {
             Consumer<Object> configUpdater = config -> updateItemBackgroundConfig(config, style);
             updateMethod.invoke(null, configUpdater);
 
-            PackCore.LOGGER.info("Successfully applied Skyblocker item background: {}", style);
+            PackCore.LOGGER.info("Successfully applied Skyblocker item background change: {}", style == null ? "DISABLE_BACKGROUNDS" : style);
             return true;
 
         } catch (ClassNotFoundException e) {
@@ -72,8 +73,11 @@ private static boolean applyItemBackgroundStyle(String style) {
     /**
      * Updates the Skyblocker config object with the new item background settings.
      *
+     * If *style* is null, this will disable item rarity backgrounds. Otherwise it will set the enum,
+     * enable rarity backgrounds and set default opacity.
+     *
      * @param config the Skyblocker config instance
-     * @param style the background style to apply
+     * @param style the background style to apply, or null to disable backgrounds
      */
     private static void updateItemBackgroundConfig(Object config, String style) {
         try {
@@ -84,22 +88,26 @@ private static void updateItemBackgroundConfig(Object config, String style) {
             Field itemInfoDisplayField = general.getClass().getField("itemInfoDisplay");
             Object itemInfoDisplay = itemInfoDisplayField.get(general);
 
-            // Set the background style enum
-            Class<?> styleEnum = Class.forName(ITEM_BACKGROUND_ENUM_CLASS);
-            Object enumValue = Enum.valueOf((Class<Enum>) styleEnum, style);
+            // Toggle itemRarityBackgrounds based on whether we have a style or are disabling
+            Field rarityBackgroundsField = itemInfoDisplay.getClass().getField("itemRarityBackgrounds");
+            rarityBackgroundsField.setBoolean(itemInfoDisplay, style != null);
 
-            Field styleField = itemInfoDisplay.getClass().getField("itemBackgroundStyle");
-            styleField.set(itemInfoDisplay, enumValue);
+            if (style != null) {
+                // Set the background style enum
+                Class<?> styleEnum = Class.forName(ITEM_BACKGROUND_ENUM_CLASS);
+                Object enumValue = Enum.valueOf((Class<Enum>) styleEnum, style);
 
-            // Enable item rarity backgrounds (required for backgrounds to show)
-            Field rarityBackgroundsField = itemInfoDisplay.getClass().getField("itemRarityBackgrounds");
-            rarityBackgroundsField.setBoolean(itemInfoDisplay, true);
+                Field styleField = itemInfoDisplay.getClass().getField("itemBackgroundStyle");
+                styleField.set(itemInfoDisplay, enumValue);
 
-            // Set default opacity
-            Field opacityField = itemInfoDisplay.getClass().getField("itemBackgroundOpacity");
-            opacityField.setFloat(itemInfoDisplay, DEFAULT_OPACITY);
+                // Set default opacity
+                Field opacityField = itemInfoDisplay.getClass().getField("itemBackgroundOpacity");
+                opacityField.setFloat(itemInfoDisplay, DEFAULT_OPACITY);
 
-            PackCore.LOGGER.debug("Item background config updated: style={}, opacity={}", style, DEFAULT_OPACITY);
+                PackCore.LOGGER.debug("Item background config updated: style={}, opacity={}", style, DEFAULT_OPACITY);
+            } else {
+                PackCore.LOGGER.debug("Item rarity backgrounds disabled via wizard selection");
+            }
 
         } catch (NoSuchFieldException e) {
             PackCore.LOGGER.error("Required config field not found - Skyblocker structure may have changed: {}", e.getMessage());
@@ -115,13 +123,17 @@ private static void updateItemBackgroundConfig(Object config, String style) {
     /**
      * Maps wizard style names to Skyblocker enum values.
      *
+     * Returns null for "none"/"no background" to indicate disabling backgrounds.
+     *
      * @param wizardStyle the style name from the wizard
-     * @return the corresponding Skyblocker enum name
+     * @return the corresponding Skyblocker enum name or null to disable backgrounds
      */
     private static String mapToSkyblockerStyle(String wizardStyle) {
-        return switch (wizardStyle.toLowerCase()) {
+        if (wizardStyle == null) return "SQUARE";
+        return switch (wizardStyle.toLowerCase().trim()) {
             case "circular" -> "CIRCULAR";
             case "square" -> "SQUARE";
+            case "no background", "none" -> null; // signal to disable itemRarityBackgrounds
             default -> {
                 PackCore.LOGGER.warn("Unknown item background style '{}', defaulting to SQUARE", wizardStyle);
                 yield "SQUARE";
@@ -131,9 +143,10 @@ private static String mapToSkyblockerStyle(String wizardStyle) {
 
     /**
      * Checks if the application should be skipped.
+     * Do not skip when the user explicitly chose "None" — that indicates they want to disable backgrounds.
      */
     private static boolean shouldSkipApplication(String itemBackground) {
-        return itemBackground == null || itemBackground.isEmpty() || "None".equalsIgnoreCase(itemBackground);
+        return itemBackground == null || itemBackground.isEmpty();
     }
 
     /**
@@ -142,4 +155,4 @@ private static boolean shouldSkipApplication(String itemBackground) {
     private static boolean isSkyblockerLoaded() {
         return FabricLoader.getInstance().isModLoaded(SKYBLOCKER_MOD_ID);
     }
-}
+}