Upgrades MudBlazor and modernizes C# syntax

Updates MudBlazor to version 8.x, adapting client-side components to new API changes for dialog instances and system dark mode detection.

Adopts C# 12 features, including primary constructors for controllers and test fixtures, and collection expressions for concise initialization. Applies the `sealed` modifier to record types for enhanced immutability.

Enhances Dependabot configuration by grouping GitHub Actions for better management and updates the ReportGenerator GitHub Action.

Author: Keboo

.github/dependabot.yml

@@ -9,3 +9,7 @@ updates:
     directory: "/" # Location of package manifests
     schedule:
       interval: "weekly"
+    groups:
+      github-actions:
+        patterns:
+          - "*"

.github/workflows/main_pointerstar.yml

@@ -35,7 +35,7 @@ jobs:
         run: dotnet test --configuration Release --no-build --collect:"XPlat Code Coverage" --results-directory ./coverage
 
       - name: ReportGenerator
-        uses: danielpalme/ReportGenerator-GitHub-Action@5.4.18
+        uses: danielpalme/ReportGenerator-GitHub-Action@5.5.0
         with:
           reports: coverage/**/coverage.cobertura.xml
           targetdir: coveragereport

Directory.Packages.props

@@ -31,7 +31,7 @@
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
     <PackageVersion Include="Moq" Version="4.20.72" />
     <PackageVersion Include="Moq.AutoMock" Version="3.5.0" />
-    <PackageVersion Include="MudBlazor" Version="7.15.0" />
+    <PackageVersion Include="MudBlazor" Version="8.14.0" />
     <PackageVersion Include="Polly" Version="8.5.2" />
     <PackageVersion Include="QRCoder" Version="1.6.0" />
     <PackageVersion Include="Toolbelt.Blazor.PWA.Updater" Version="3.0.1" />

PointerStar/Client/Components/UserDialog.razor

@@ -36,7 +36,7 @@
 
 @code {
     [CascadingParameter]
-    private MudDialogInstance? MudDialog { get; set; }
+    private IMudDialogInstance? MudDialog { get; set; }
     [Parameter]
     public string? RoomId { get; set; }
     [Parameter]

PointerStar/Client/Shared/MainLayout.razor

@@ -26,8 +26,8 @@
     {
         if (firstRender && _mudThemeProvider is { } themeProvider)
         {
-            _isDarkMode = await themeProvider.GetSystemPreference();
-            await themeProvider.WatchSystemPreference(OnSystemPreferenceChanged);
+            _isDarkMode = await themeProvider.GetSystemDarkModeAsync();
+            await themeProvider.WatchSystemDarkModeAsync(OnSystemPreferenceChanged);
             StateHasChanged();
         }
     }

PointerStar/Server/Controllers/RoomController.cs

@@ -1,4 +1,4 @@
-using HashidsNet;
+using HashidsNet;
 using Microsoft.AspNetCore.Mvc;
 using PointerStar.Server.Room;
 using PointerStar.Shared;
@@ -7,18 +7,11 @@ namespace PointerStar.Server.Controllers;
 
 [ApiController]
 [Route("api/[controller]")]
-public class RoomController : ControllerBase
+public class RoomController(Hashids hashIds, IRoomManager roomManager) : ControllerBase
 {
     private static readonly Random Random = new();
-    private Hashids HashIds { get; }
-    private IRoomManager RoomManager { get; }
-
-    public RoomController(Hashids hashIds, IRoomManager roomManager)
-    {
-        HashIds = hashIds ?? throw new ArgumentNullException(nameof(hashIds));
-        RoomManager = roomManager ?? throw new ArgumentNullException(nameof(roomManager));
-    }
-
+    private Hashids HashIds { get; } = hashIds ?? throw new ArgumentNullException(nameof(hashIds));
+    private IRoomManager RoomManager { get; } = roomManager ?? throw new ArgumentNullException(nameof(roomManager));
 
     [HttpGet("Generate")]
     public string Generate()

PointerStar/Shared/RoomState.cs

@@ -1,6 +1,6 @@
 namespace PointerStar.Shared;
 
-public record class RoomState(string RoomId, User[] Users)
+public sealed record class RoomState(string RoomId, User[] Users)
 {
     public IReadOnlyList<User> TeamMembers
         => [.. Users.Where(u => u.Role == Role.TeamMember)];
@@ -30,7 +30,7 @@ public IReadOnlyList<User> Observers
     public DateTime? VoteStartTime { get; init; }
 }
 
-public record class User(Guid Id, string Name)
+public sealed record class User(Guid Id, string Name)
 {
     public const int MaxNameLength = 40;
 
@@ -39,7 +39,7 @@ public record class User(Guid Id, string Name)
     public Role Role { get; init; } = Role.TeamMember;
 }
 
-public record class Role(Guid Id, string Name)
+public sealed record class Role(Guid Id, string Name)
 {
     private static readonly Guid FacilitatorId = new("5fea7d71-fb62-405c-823c-09752c684bf0");
     private static readonly Guid TeamMemberId = new("116b133b-b16d-4a92-a3ce-ae53688e973c");

Tests/PointerStar.Client.Tests/ViewModels/RoomViewModelTests.cs

@@ -113,8 +113,8 @@ public async Task ConnectToRoomAsync_WithExistingRoomState_UpdatesUser()
         viewModel.RoomId = "RoomId";
         await viewModel.OnInitializedAsync();
         viewModel.Name = "Foo";
-        var roomState = new RoomState("roomId", new[] { new User(Guid.NewGuid(), "Test") });
-        mocker.GetMock<IRoomHubConnection>().Raise(x => x.RoomStateUpdated += null, null, roomState);
+        var roomState = new RoomState("roomId", [new User(Guid.NewGuid(), "Test")]);
+        mocker.GetMock<IRoomHubConnection>().Raise(x => x.RoomStateUpdated += null, null!, roomState);
 
         viewModel.Name = "New Name";
         viewModel.SelectedRoleId = Role.Observer.Id;
@@ -165,7 +165,7 @@ public async Task OnInitializedAsync_WithVoteStartTime_PeriodicallyNotifiesOfSta
         viewModel.RoomId = "RoomId";
         await viewModel.OnInitializedAsync();
         User facilitator = new(Guid.NewGuid(), "Facilitator") { Role = Role.Facilitator };
-        RoomState roomState = new(Guid.NewGuid().ToString(), new[] { facilitator })
+        RoomState roomState = new(Guid.NewGuid().ToString(), [facilitator])
         {
             VoteStartTime = DateTime.UtcNow.AddMinutes(-1)
         };
@@ -174,7 +174,7 @@ public async Task OnInitializedAsync_WithVoteStartTime_PeriodicallyNotifiesOfSta
 
         //We expect a timer or similar to trigger state changes to make it appear as though the timer is updating
         ManualResetEventSlim mre = new(false);
-        viewModel.PropertyChanged += (object? _, PropertyChangedEventArgs e) =>
+        viewModel.PropertyChanged += (_, e) =>
         {
             mre.Set();
         };
@@ -272,7 +272,7 @@ public void IsFacilitator_WithFacilitatorUser_ReturnsTrue()
     {
         AutoMocker mocker = new();
         User facilitator = new(Guid.NewGuid(), "Facilitator") { Role = Role.Facilitator };
-        RoomState roomState = new(Guid.NewGuid().ToString(), new[] { facilitator });
+        RoomState roomState = new(Guid.NewGuid().ToString(), [facilitator]);
         RoomViewModel viewModel = mocker.CreateInstance<RoomViewModel>();
         viewModel.CurrentUserId = facilitator.Id;
         WithRoomState(mocker, roomState);
@@ -288,7 +288,7 @@ public void IsTeamMember_WithTeamMemberUser_ReturnsTrue()
     {
         AutoMocker mocker = new();
         User teamMember = new(Guid.NewGuid(), "Team Member") { Role = Role.TeamMember };
-        RoomState roomState = new(Guid.NewGuid().ToString(), new[] { teamMember });
+        RoomState roomState = new(Guid.NewGuid().ToString(), [teamMember]);
         RoomViewModel viewModel = mocker.CreateInstance<RoomViewModel>();
         viewModel.CurrentUserId = teamMember.Id;
         WithRoomState(mocker, roomState);
@@ -304,7 +304,7 @@ public void IsObserver_WithObserverUser_ReturnsTrue()
     {
         AutoMocker mocker = new();
         User observer = new(Guid.NewGuid(), "Observer") { Role = Role.Observer };
-        RoomState roomState = new(Guid.NewGuid().ToString(), new[] { observer });
+        RoomState roomState = new(Guid.NewGuid().ToString(), [observer]);
         RoomViewModel viewModel = mocker.CreateInstance<RoomViewModel>();
         viewModel.CurrentUserId = observer.Id;
         WithRoomState(mocker, roomState);
@@ -366,7 +366,7 @@ public async Task RemoveUserAsync_WithUserId_RemovesUser()
         AutoMocker mocker = new();
         mocker.Setup<IRoomHubConnection, bool>(x => x.IsConnected).Returns(true);
         User teamMember = new(Guid.NewGuid(), "Team Member") { Role = Role.TeamMember };
-        RoomState roomState = new(Guid.NewGuid().ToString(), new[] { teamMember });
+        RoomState roomState = new(Guid.NewGuid().ToString(), [teamMember]);
         RoomViewModel viewModel = mocker.CreateInstance<RoomViewModel>();
         WithRoomState(mocker, roomState);
 
@@ -390,7 +390,5 @@ private static void WithUserDialog(AutoMocker mocker, string? name, Guid? select
     }
 
     private static void WithRoomState(AutoMocker mocker, RoomState roomState)
-    {
-        mocker.GetMock<IRoomHubConnection>().Raise(x => x.RoomStateUpdated += null, null, roomState);
-    }
+        => mocker.GetMock<IRoomHubConnection>().Raise(x => x.RoomStateUpdated += null, null!, roomState);
 }

Tests/PointerStar.Server.Tests/Controllers/RoomControllerTests.cs

@@ -5,14 +5,9 @@
 namespace PointerStar.Server.Tests.Controllers;
 
 [ConstructorTests(typeof(RoomController))]
-public partial class RoomControllerTests : IClassFixture<WebApplicationFactory>
+public partial class RoomControllerTests(WebApplicationFactory factory) : IClassFixture<WebApplicationFactory>
 {
-    private WebApplicationFactory Factory { get; }
-
-    public RoomControllerTests(WebApplicationFactory factory)
-    {
-        Factory = factory;
-    }
+    private WebApplicationFactory Factory { get; } = factory;
 
     [Fact]
     public async Task Generate_ReturnsUniqueStrings()

Tests/PointerStar.Server.Tests/WebApplicationFactory.cs

@@ -6,7 +6,7 @@ namespace PointerStar.Server.Tests;
 
 public class WebApplicationFactory : WebApplicationFactory<Program>
 {
-    private List<ServiceDescriptor> AdditionalServices { get; } = new();
+    private List<ServiceDescriptor> AdditionalServices { get; } = [];
 
     public void UseService<TInterface>(TInterface instance)
         where TInterface : notnull