Skip to content

Commit a5a0007

Browse files
authored
Use actual dimen resource id instead of target id (#158)
* Make sample use dimen resources * Use actual dimen resource ID
1 parent 89bfae7 commit a5a0007

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

app/src/main/java/com/getkeepsafe/taptargetviewsample/MainActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ public void onTargetClick(TapTargetView view) {
103103
TapTargetView.showFor(this, TapTarget.forView(findViewById(R.id.fab), "Hello, world!", spannedDesc)
104104
.cancelable(false)
105105
.drawShadow(true)
106+
.titleTextDimen(R.dimen.title_text_size)
106107
.tintTarget(false), new TapTargetView.Listener() {
107108
@Override
108109
public void onTargetClick(TapTargetView view) {

app/src/main/res/values/dimens.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
<!-- Default screen margins, per the Android Design guidelines. -->
33
<dimen name="activity_horizontal_margin">16dp</dimen>
44
<dimen name="activity_vertical_margin">16dp</dimen>
5+
<dimen name="title_text_size">20dp</dimen>
56
</resources>

taptargetview/src/main/java/com/getkeepsafe/taptargetview/TapTarget.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ private Integer colorResOrInt(Context context, @Nullable Integer value, @ColorRe
469469

470470
private int dimenOrSize(Context context, int size, @DimenRes int dimen) {
471471
if (dimen != -1) {
472-
return context.getResources().getDimensionPixelSize(id);
472+
return context.getResources().getDimensionPixelSize(dimen);
473473
}
474474

475475
return UiUtil.sp(context, size);

0 commit comments

Comments
 (0)