Skip to content

Commit 428d4c7

Browse files
fix(rule): report error message when type scope or body empty (#445)
Signed-off-by: xieyongbin <xieyongbin@126.com> Co-authored-by: KeisukeYamashita <19yamashita15@gmail.com>
1 parent 4f0517a commit 428d4c7

File tree

3 files changed

+9
-33
lines changed

3 files changed

+9
-33
lines changed

cli/src/rule/body_max_length.rs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,12 @@ impl Rule for BodyMaxLength {
2727
}
2828

2929
fn validate(&self, message: &Message) -> Option<Violation> {
30-
match &message.body {
31-
Some(body) => {
32-
if body.len() >= self.length {
33-
return Some(Violation {
34-
level: self.level.unwrap_or(Self::LEVEL),
35-
message: self.message(message),
36-
});
37-
}
38-
}
39-
None => {
30+
if let Some(body) = &message.body {
31+
if body.len() >= self.length {
4032
return Some(Violation {
4133
level: self.level.unwrap_or(Self::LEVEL),
4234
message: self.message(message),
43-
})
35+
});
4436
}
4537
}
4638

cli/src/rule/scope_max_length.rs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,12 @@ impl Rule for ScopeMaxLength {
2727
}
2828

2929
fn validate(&self, message: &Message) -> Option<Violation> {
30-
match &message.scope {
31-
Some(scope) => {
32-
if scope.len() >= self.length {
33-
return Some(Violation {
34-
level: self.level.unwrap_or(Self::LEVEL),
35-
message: self.message(message),
36-
});
37-
}
38-
}
39-
None => {
30+
if let Some(scope) = &message.scope {
31+
if scope.len() >= self.length {
4032
return Some(Violation {
4133
level: self.level.unwrap_or(Self::LEVEL),
4234
message: self.message(message),
43-
})
35+
});
4436
}
4537
}
4638

cli/src/rule/type_max_length.rs

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,12 @@ impl Rule for TypeMaxLength {
2727
}
2828

2929
fn validate(&self, message: &Message) -> Option<Violation> {
30-
match &message.r#type {
31-
Some(t) => {
32-
if t.len() >= self.length {
33-
return Some(Violation {
34-
level: self.level.unwrap_or(Self::LEVEL),
35-
message: self.message(message),
36-
});
37-
}
38-
}
39-
None => {
30+
if let Some(t) = &message.r#type {
31+
if t.len() >= self.length {
4032
return Some(Violation {
4133
level: self.level.unwrap_or(Self::LEVEL),
4234
message: self.message(message),
43-
})
35+
});
4436
}
4537
}
4638

0 commit comments

Comments
 (0)