fix: replace printf/fprintf with serial_printf, fix SpeechManager NULL checks

Bare metal safety:
- TrapDispatcher BadTrap: replace printf with serial_printf (printf
  routes to serial anyway but extern is cleaner for bare metal)
- TrapDispatcher SysError: replace fprintf(stderr,...) with serial_printf
- MenuBarManager InitMenuBar: replace printf with serial_puts

SpeechManager hardening:
- GetAudioOutputDeviceCapabilities: NULL-check all 3 output params
  before dereferencing (formats, formatCount, supportedFlags)
- GetAudioStreamProperty: NULL-check valueSize before writing
- GetSpeechRate/GetSpeechPitch: remove redundant NULL checks after
  already-validated parameter (dead code)

Author: Kelsidavis

src/MenuManager/MenuBarManager.c

@@ -19,7 +19,8 @@
 
 /* Menu bar management */
 void InitMenuBar(void) {
-    printf("Initializing menu bar\n");
+    extern void serial_puts(const char* str);
+    serial_puts("Initializing menu bar\n");
     InitMenus();
 }
 

src/SpeechManager/SpeechManagerCore.c

@@ -240,10 +240,8 @@ OSErr GetSpeechRate(SpeechChannel chan, Fixed *rate) {
         }
     }
 
-    if (rate) {
-        *rate = 0x00010000;
-    }
-    return noErr;  // Stub
+    *rate = 0x00010000;  /* Fixed 1.0 = normal rate */
+    return noErr;
 }
 
 /*
@@ -281,10 +279,8 @@ OSErr GetSpeechPitch(SpeechChannel chan, Fixed *pitch) {
         }
     }
 
-    if (pitch) {
-        *pitch = 0x00010000;
-    }
-    return noErr;  // Stub
+    *pitch = 0x00010000;  /* Fixed 1.0 = normal pitch */
+    return noErr;
 }
 
 /*

src/SpeechManager/SpeechOutput_Stub.c

@@ -335,7 +335,10 @@ OSErr GetAudioOutputVolume(Fixed *volume) {
 
 OSErr GetAudioOutputDeviceCapabilities(const char *deviceID, AudioOutputFormat **formats,
                                        short *formatCount, AudioOutputFlags *supportedFlags) {
+    (void)deviceID;
+    if (formats) *formats = NULL;
     if (formatCount) *formatCount = 0;
+    if (supportedFlags) *supportedFlags = 0;
     return noErr;
 }
 
@@ -413,6 +416,8 @@ OSErr SetAudioStreamProperty(AudioOutputStream *stream, OSType property, const v
 
 OSErr GetAudioStreamProperty(AudioOutputStream *stream, OSType property, void *value,
                              long *valueSize) {
+    (void)stream; (void)property; (void)value;
+    if (valueSize) *valueSize = 0;
     return noErr;
 }
 

src/TrapDispatcher.c

@@ -348,8 +348,11 @@ FLineTrapHandler TrapDispatcher_SetFLineHandler(FLineTrapHandler handler) {
  */
 SInt32 TrapDispatcher_BadTrap(TrapContext *context) {
     /* Save all registers in debugger space - this would be system-specific */
-    printf("BadTrap: Unimplemented trap at PC=0x%08X, trap_word=0x%04X\n",
-           context->pc - 2, *(UInt16*)(uintptr_t)(context->pc - 2));
+    {
+        extern void serial_printf(const char* fmt, ...);
+        serial_printf("BadTrap: Unimplemented trap at PC=0x%08X, trap_word=0x%04X\n",
+                      context->pc - 2, *(UInt16*)(uintptr_t)(context->pc - 2));
+    }
 
     /* In original Mac OS, this would call SysError with DS_CORE_ERR */
     SysError(DS_CORE_ERR);
@@ -466,7 +469,8 @@ static SInt32 unimplemented_trap_handler(TrapContext *context) {
 
 /* Weak symbol definitions for system functions that should be provided externally */
 __attribute__((weak)) void SysError(int error_code) {
-    fprintf(stderr, "SYSTEM ERROR %d: Unimplemented trap or critical failure\n", error_code);
+    extern void serial_printf(const char* fmt, ...);
+    serial_printf("SYSTEM ERROR %d: Unimplemented trap or critical failure\n", error_code);
     abort();
 }