Change auth settings retrieval order in Get-CippApiAuth

Now retrieves authentication settings via Azure REST API first, falling back to the WEBSITE_AUTH_V2_CONFIG_JSON environment variable only if the REST call fails. This improves reliability by prioritizing live configuration data.

Author: JohnDuprey

Modules/CIPPCore/Public/Authentication/Get-CippApiAuth.ps1

@@ -4,17 +4,15 @@ function Get-CippApiAuth {
         [string]$FunctionAppName
     )
 
-    if ($env:WEBSITE_AUTH_V2_CONFIG_JSON) {
-        $AuthSettings = $env:WEBSITE_AUTH_V2_CONFIG_JSON | ConvertFrom-Json -ErrorAction SilentlyContinue
-    }
+    $SubscriptionId = Get-CIPPAzFunctionAppSubId
 
-    if (-not $AuthSettings) {
-        $SubscriptionId = Get-CIPPAzFunctionAppSubId
+    # Get auth settings via REST
+    $uri = "https://management.azure.com/subscriptions/$SubscriptionId/resourceGroups/$RGName/providers/Microsoft.Web/sites/$($FunctionAppName)/config/authsettingsV2/list?api-version=2020-06-01"
+    $response = New-CIPPAzRestRequest -Uri $uri -Method POST -ErrorAction Stop
+    $AuthSettings = $response.properties
 
-        # Get auth settings via REST
-        $uri = "https://management.azure.com/subscriptions/$SubscriptionId/resourceGroups/$RGName/providers/Microsoft.Web/sites/$($FunctionAppName)/config/authsettingsV2/list?api-version=2020-06-01"
-        $response = New-CIPPAzRestRequest -Uri $uri -Method POST -ErrorAction Stop
-        $AuthSettings = $response.properties
+    if (!$AuthSettings -and $env:WEBSITE_AUTH_V2_CONFIG_JSON) {
+        $AuthSettings = $env:WEBSITE_AUTH_V2_CONFIG_JSON | ConvertFrom-Json -ErrorAction SilentlyContinue
     }
 
     if ($AuthSettings) {