Remove debug and timing logs from Add-CIPPAzDataTableEntity and Add-CIPPDbItem

Eliminated detailed timing and debug output from Add-CIPPAzDataTableEntity.ps1 to reduce log verbosity and improve performance. Commented out Write-Debug statements in Add-CIPPDbItem.ps1 and added property selection to Get-CIPPAzDataTableEntity for efficiency.

Author: JohnDuprey

Modules/CIPPCore/Public/Add-CIPPAzDataTableEntity.ps1

@@ -40,12 +40,6 @@ function Add-CIPPAzDataTableEntity {
     $MaxRowSize = 500000 - 100
     $MaxSize = 30kb
 
-    $startTime = Get-Date
-    $entityCount = @($Entity).Count
-    $totalValidationTime = 0
-    $totalAddTime = 0
-    Write-Information "[Add-CIPPAzDataTableEntity] Processing $entityCount entities"
-
     foreach ($SingleEnt in @($Entity)) {
         try {
             # Skip null entities
@@ -68,7 +62,6 @@ function Add-CIPPAzDataTableEntity {
             }
 
             # Additional validation for AzBobbyTables compatibility
-            $validationStart = Get-Date
             try {
                 # Ensure all property values are not null for string properties
                 if ($SingleEnt -is [hashtable]) {
@@ -91,15 +84,8 @@ function Add-CIPPAzDataTableEntity {
             } catch {
                 Write-Warning "Error during entity validation: $($_.Exception.Message)"
             }
-            $validationEnd = Get-Date
-            $validationDuration = ($validationEnd - $validationStart).TotalMilliseconds
-            $totalValidationTime += $validationDuration
 
-            $addStart = Get-Date
             Add-AzDataTableEntity @Parameters -Entity $SingleEnt -ErrorAction Stop
-            $addEnd = Get-Date
-            $addDuration = ($addEnd - $addStart).TotalMilliseconds
-            $totalAddTime += $addDuration
 
         } catch [System.Exception] {
             if ($_.Exception.ErrorCode -in @('PropertyValueTooLarge', 'EntityTooLarge', 'RequestBodyTooLarge')) {
@@ -251,10 +237,4 @@ function Add-CIPPAzDataTableEntity {
             }
         }
     }
-
-    $endTime = Get-Date
-    $totalDuration = [math]::Round(($endTime - $startTime).TotalSeconds, 2)
-    $avgValidation = [math]::Round($totalValidationTime / $entityCount, 2)
-    $avgAdd = [math]::Round($totalAddTime / $entityCount, 2)
-    Write-Debug "[Add-CIPPAzDataTableEntity] Completed $entityCount entities in ${totalDuration}s (avg validation: ${avgValidation}ms, avg add: ${avgAdd}ms)"
 }

Modules/CIPPCore/Public/Add-CIPPDbItem.ps1

@@ -99,19 +99,19 @@ function Add-CIPPDbItem {
                 $MemoryAfterGC = [System.GC]::GetTotalMemory($false)
                 $FreedMB = [math]::Round(($MemoryBeforeGC - $MemoryAfterGC) / 1MB, 2)
                 $CurrentMemoryMB = [math]::Round($MemoryAfterGC / 1MB, 2)
-                Write-Debug "Batch $($State.BatchNumber): ${flushDuration}s total (write: ${writeDuration}s, gc: ${gcDuration}s) | Processed: $($State.TotalProcessed) | Memory: ${CurrentMemoryMB}MB | Freed: ${FreedMB}MB"
+                #Write-Debug "Batch $($State.BatchNumber): ${flushDuration}s total (write: ${writeDuration}s, gc: ${gcDuration}s) | Processed: $($State.TotalProcessed) | Memory: ${CurrentMemoryMB}MB | Freed: ${FreedMB}MB"
             }
         }
 
         if (-not $Count.IsPresent) {
             # Delete existing entries for this type
             $Filter = "PartitionKey eq '{0}' and RowKey ge '{1}-' and RowKey lt '{1}0'" -f $TenantFilter, $Type
-            $ExistingEntities = Get-CIPPAzDataTableEntity @Table -Filter $Filter
+            $ExistingEntities = Get-CIPPAzDataTableEntity @Table -Filter $Filter -Property PartitionKey, RowKey, ETag
             if ($ExistingEntities) {
                 Remove-AzDataTableEntity @Table -Entity $ExistingEntities -Force | Out-Null
             }
             $AllocatedMemoryMB = [math]::Round([System.GC]::GetTotalMemory($false) / 1MB, 2)
-            Write-Debug "Starting $Type import for $TenantFilter | Allocated Memory: ${AllocatedMemoryMB}MB | Batch Size: 500"
+            #Write-Debug "Starting $Type import for $TenantFilter | Allocated Memory: ${AllocatedMemoryMB}MB | Batch Size: 500"
         }
     }
 
@@ -184,7 +184,7 @@ function Add-CIPPDbItem {
             Write-LogMessage -API 'CIPPDbItem' -tenant $TenantFilter `
                 -message "Failed to add items of type $Type : $($_.Exception.Message)" -sev Error `
                 -LogData (Get-CippException -Exception $_)
-            Write-Debug "[Add-CIPPDbItem] $TenantFilter - $(Get-CippException -Exception $_ | ConvertTo-Json -Depth 5 -Compress)"
+            #Write-Debug "[Add-CIPPDbItem] $TenantFilter - $(Get-CippException -Exception $_ | ConvertTo-Json -Depth 5 -Compress)"
             throw
         } finally {
             # Record count if AddCount was specified