Skip to content

Commit a831dd6

Browse files
authored
Merge pull request #5490 from KelvinTegelaar/dev
Dev to hotfix
2 parents 242bce1 + b974afb commit a831dd6

File tree

29 files changed

+938
-1166
lines changed

29 files changed

+938
-1166
lines changed

.github/workflows/Assign_Issue_Volunteer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ jobs:
55
build:
66
runs-on: ubuntu-slim
77
steps:
8-
- uses: bhermann/issue-volunteer@v0.1.12
8+
- uses: bhermann/issue-volunteer@v0.1.20
99
with:
1010
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/Comment_on_Issues.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
issues: write
1313
steps:
1414
- name: Add Comment
15-
uses: peter-evans/create-or-update-comment@v3
15+
uses: peter-evans/create-or-update-comment@v5
1616
with:
1717
issue-number: ${{ github.event.issue.number }}
1818
body: |

.github/workflows/auto_comments.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
# 1) If the comment includes '!notasponsor', delete it using GitHub Script
1818
- name: Delete !notasponsor comment
1919
if: contains(github.event.comment.body, '!notasponsor')
20-
uses: actions/github-script@v6
20+
uses: actions/github-script@v8
2121
with:
2222
github-token: ${{ secrets.GITHUB_TOKEN }}
2323
script: |
@@ -30,7 +30,7 @@ jobs:
3030
# 2) Post a sponsor-specific reply
3131
- name: Reply to !notasponsor
3232
if: contains(github.event.comment.body, '!notasponsor')
33-
uses: peter-evans/create-or-update-comment@v3
33+
uses: peter-evans/create-or-update-comment@v5
3434
with:
3535
issue-number: ${{ github.event.issue.number }}
3636
body: |
@@ -51,7 +51,7 @@ jobs:
5151
# 3) If the comment includes '!support', classify as a support request
5252
- name: Reply to !support
5353
if: contains(github.event.comment.body, '!support')
54-
uses: peter-evans/create-or-update-comment@v3
54+
uses: peter-evans/create-or-update-comment@v5
5555
with:
5656
issue-number: ${{ github.event.issue.number }}
5757
body: |
@@ -69,7 +69,7 @@ jobs:
6969
# 4) If the comment includes '!incomplete', note the bug or feature request is incomplete
7070
- name: Reply to !incomplete
7171
if: contains(github.event.comment.body, '!incomplete')
72-
uses: peter-evans/create-or-update-comment@v3
72+
uses: peter-evans/create-or-update-comment@v5
7373
with:
7474
issue-number: ${{ github.event.issue.number }}
7575
body: |

.github/workflows/cipp_dev_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
4848
# Upload to Azure Blob Storage
4949
- name: Azure Blob Upload
50-
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.1
50+
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.7.0
5151
with:
5252
connection_string: ${{ secrets.AZURE_CONNECTION_STRING }}
5353
container_name: cipp

.github/workflows/cipp_frontend_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
4848
# Upload to Azure Blob Storage
4949
- name: Azure Blob Upload
50-
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.3.1
50+
uses: LanceMcCarthy/Action-AzureBlobUpload@v3.7.0
5151
with:
5252
connection_string: ${{ secrets.AZURE_CONNECTION_STRING }}
5353
container_name: cipp

.github/workflows/label_sponsor_requests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
issues: write
1212
steps:
1313
- name: Sponsor Labels
14-
uses: JasonEtco/is-sponsor-label-action@v1.2.0
14+
uses: JasonEtco/is-sponsor-label-action@v2.0.0
1515
with:
1616
label: "Sponsor Priority"
1717
env:

.github/workflows/pr_check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
github.event.pull_request.head.repo.fork == true &&
2626
((github.event.pull_request.head.ref == 'main' || github.event.pull_request.head.ref == 'master') ||
2727
(github.event.pull_request.base.ref == 'main' || github.event.pull_request.base.ref == 'master'))
28-
uses: actions/github-script@v7
28+
uses: actions/github-script@v8
2929
with:
3030
github-token: ${{ secrets.GITHUB_TOKEN }}
3131
script: |

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cipp",
3-
"version": "10.1.1",
3+
"version": "10.1.2",
44
"author": "CIPP Contributors",
55
"homepage": "https://cipp.app/",
66
"bugs": {
@@ -51,7 +51,7 @@
5151
"@tiptap/extension-table": "^3.19.0",
5252
"@tiptap/pm": "^3.4.1",
5353
"@tiptap/react": "^3.4.1",
54-
"@tiptap/starter-kit": "^3.19.0",
54+
"@tiptap/starter-kit": "^3.20.0",
5555
"@uiw/react-json-view": "^2.0.0-alpha.41",
5656
"@vvo/tzdb": "^6.198.0",
5757
"apexcharts": "5.3.5",
@@ -61,9 +61,9 @@
6161
"export-to-csv": "^1.3.0",
6262
"formik": "2.4.9",
6363
"gray-matter": "4.0.3",
64-
"i18next": "25.5.2",
64+
"i18next": "25.8.13",
6565
"javascript-time-ago": "^2.6.2",
66-
"jspdf": "^4.1.0",
66+
"jspdf": "^4.2.0",
6767
"jspdf-autotable": "^5.0.7",
6868
"leaflet": "^1.9.4",
6969
"leaflet-defaulticon-compatibility": "^0.1.2",

public/version.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"version": "10.1.1"
3-
}
2+
"version": "10.1.2"
3+
}

src/components/CippComponents/CippAddUserDrawer.jsx

Lines changed: 48 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const CippAddUserDrawer = ({
1818
const userSettingsDefaults = useSettings();
1919

2020
const formControl = useForm({
21-
mode: "onBlur",
21+
mode: "onChange",
2222
defaultValues: {
2323
tenantFilter: userSettingsDefaults.currentTenant,
2424
usageLocation: userSettingsDefaults.usageLocation,
@@ -52,22 +52,36 @@ export const CippAddUserDrawer = ({
5252
}
5353
newFields.tenantFilter = userSettingsDefaults.currentTenant;
5454

55+
// Preserve the currently selected template when copying properties
56+
const currentTemplate = formControl.getValues("userTemplate");
57+
if (currentTemplate) {
58+
newFields.userTemplate = currentTemplate;
59+
}
60+
5561
formControl.reset(newFields);
5662
}
5763
}, [formValues]);
5864

5965
useEffect(() => {
6066
if (createUser.isSuccess) {
61-
formControl.reset({
67+
const resetValues = {
6268
tenantFilter: userSettingsDefaults.currentTenant,
6369
usageLocation: userSettingsDefaults.usageLocation,
64-
});
70+
};
71+
72+
// Preserve the default template if it exists
73+
const currentTemplate = formControl.getValues("userTemplate");
74+
if (currentTemplate?.addedFields?.defaultForTenant) {
75+
resetValues.userTemplate = currentTemplate;
76+
}
77+
78+
formControl.reset(resetValues);
6579
}
6680
}, [createUser.isSuccess]);
6781

68-
const handleSubmit = () => {
69-
formControl.trigger();
70-
if (!isValid) {
82+
const handleSubmit = async () => {
83+
const isFormValid = await formControl.trigger();
84+
if (!isFormValid) {
7185
return;
7286
}
7387
const values = formControl.getValues();
@@ -84,17 +98,40 @@ export const CippAddUserDrawer = ({
8498

8599
const handleCloseDrawer = () => {
86100
setDrawerVisible(false);
87-
formControl.reset({
101+
const resetValues = {
88102
tenantFilter: userSettingsDefaults.currentTenant,
89103
usageLocation: userSettingsDefaults.usageLocation,
90-
});
104+
};
105+
106+
// Preserve the default template if it exists
107+
const currentTemplate = formControl.getValues("userTemplate");
108+
if (currentTemplate?.addedFields?.defaultForTenant) {
109+
resetValues.userTemplate = currentTemplate;
110+
}
111+
112+
formControl.reset(resetValues);
113+
};
114+
115+
const handleOpenDrawer = () => {
116+
const resetValues = {
117+
tenantFilter: userSettingsDefaults.currentTenant,
118+
usageLocation: userSettingsDefaults.usageLocation,
119+
};
120+
121+
const currentTemplate = formControl.getValues("userTemplate");
122+
if (currentTemplate?.addedFields?.defaultForTenant) {
123+
resetValues.userTemplate = currentTemplate;
124+
}
125+
126+
formControl.reset(resetValues);
127+
setDrawerVisible(true);
91128
};
92129

93130
return (
94131
<>
95132
<PermissionButton
96133
requiredPermissions={requiredPermissions}
97-
onClick={() => setDrawerVisible(true)}
134+
onClick={handleOpenDrawer}
98135
startIcon={<PersonAdd />}
99136
>
100137
{buttonText}
@@ -117,8 +154,8 @@ export const CippAddUserDrawer = ({
117154
{createUser.isPending
118155
? "Creating User..."
119156
: createUser.isSuccess
120-
? "Create Another User"
121-
: "Create User"}
157+
? "Create Another User"
158+
: "Create User"}
122159
</Button>
123160
<Button variant="outlined" onClick={handleCloseDrawer}>
124161
Close

0 commit comments

Comments
 (0)