fix typos

Author: benvanwerkhoven

kernel_tuner/observers/nvml.py

@@ -352,7 +352,7 @@ def __init__(
         save_all=False,
         nvidia_smi_fallback=None,
         use_locked_clocks=False,
-        continous_duration=1,
+        continuous_duration=1,
     ):
         """Create an NVMLObserver."""
         if nvidia_smi_fallback:
@@ -384,7 +384,7 @@ def __init__(
         if any([obs in self.needs_power for obs in observables]):
             self.measure_power = True
             power_observables = [obs for obs in observables if obs in self.needs_power]
-            self.continuous_observer = ContinuousObserver("nvml", self, power_observables, continous_duration=continuous_duration)
+            self.continuous_observer = ContinuousObserver("nvml", power_observables, self, continuous_duration=continuous_duration)
 
         # remove power observables
         self.observables = [obs for obs in observables if obs not in self.needs_power]
@@ -407,7 +407,8 @@ def __init__(
         self.iteration = {obs: [] for obs in self.during_obs}
 
     def read_power(self):
-        return self.nvml.pwr_usage()
+        """ Return power in Watt """
+        return self.nvml.pwr_usage() / 1e3
 
     def before_start(self):
         # clear results of the observables for next measurement

kernel_tuner/observers/observer.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
-
+import time
+import numpy as np
 
 class BenchmarkObserver(ABC):
     """Base class for Benchmark Observers"""
@@ -47,9 +48,9 @@ class ContinuousObserver(BenchmarkObserver):
     """Generic observer that measures power while and continuous benchmarking.
 
         To support continuous benchmarking an Observer should support:
-        a .read_power() method, which the ContinuousObserver can call to read power
+        a .read_power() method, which the ContinuousObserver can call to read power in Watt
     """
-    def __init__(self, name, observables, parent, continous_duration=1):
+    def __init__(self, name, observables, parent, continuous_duration=1):
         self.parent = parent
         self.name = name
 
@@ -60,7 +61,7 @@ def __init__(self, name, observables, parent, continous_duration=1):
         self.observables = observables
 
         # duration in seconds
-        self.continuous_duration = continous_duration
+        self.continuous_duration = continuous_duration
 
         self.power = 0
         self.energy = 0

kernel_tuner/observers/tegra.py

@@ -224,7 +224,7 @@ def __init__(
         if any([obs in self.needs_power for obs in observables]):
             self.measure_power = True
             power_observables = [obs for obs in observables if obs in self.needs_power]
-            self.continuous_observer = ContinuousObserver("tegra", power_observables, self, continous_duration=3)
+            self.continuous_observer = ContinuousObserver("tegra", power_observables, self, continuous_duration=3)
 
         # remove power observables
         self.observables = [obs for obs in observables if obs not in self.needs_power]