Skip to content

Commit ecf20bd

Browse files
authored
Merge pull request #9 from KevinAst/initial
publish: v0.1.1 react-native android patch
2 parents 2d2d2c9 + 0f4f4d4 commit ecf20bd

File tree

3 files changed

+87
-6
lines changed

3 files changed

+87
-6
lines changed

CHANGELOG.md

Lines changed: 77 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,81 @@
11
# Change Log
22

3-
The **feature-redux**project adheres to [Semantic
3+
The **feature-redux** project adheres to [Semantic
44
Versioning](http://semver.org/).
55

6-
Each release, along with migration instructions, is documented on the
7-
[Github Releases](https://github.com/KevinAst/feature-redux/releases)
8-
page.
6+
Each release is documented on this page *(in addition to the [Github
7+
Release Notes](https://github.com/KevinAst/feature-redux/releases))*,
8+
and **contains migration instructions**.
9+
10+
## Summary:
11+
12+
Release | What | *When*
13+
---------|-------------------------------------------------|------------------
14+
[v0.1.1] | react-native android patch | *March 7, 2018*
15+
[v0.1.0] | Initial Release | *March 6, 2018*
16+
17+
[v0.1.1]: #v011---react-native-android-patch-march-7-2018
18+
[v0.1.0]: #v010---initial-release-march-6-2018
19+
20+
21+
22+
<!-- UNRELEASED **************************************************************************
23+
24+
TEMPLATE:
25+
## vn.n.n - DESC *(DATE ?, 2018)*
26+
27+
[GitHub Content](https://github.com/KevinAst/feature-redux/tree/vn.n.n)
28+
&bull;
29+
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/vn.n.n)
30+
31+
RUNNING CONTENT (pop out as needed) ...
32+
33+
UNRELEASED ******************************************************************************** -->
34+
35+
36+
37+
38+
39+
<!-- *** RELEASE *************************************************************** -->
40+
41+
## v0.1.1 - react-native android patch *(March 7, 2018)*
42+
43+
[GitHub Content](https://github.com/KevinAst/feature-redux/tree/v0.1.1)
44+
&bull;
45+
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/v0.1.1)
46+
47+
**NOTE**: This release is a **non-breaking change** _(i.e. no API was affected)_.
48+
49+
- A patch was applied in support of **react-native android**.
50+
51+
When running react-native under android, receiving the following
52+
exception:
53+
54+
```
55+
ERROR: undefined is not a function
56+
evaluating 'content[typeof Symbol === 'function' ? Symbol.iterator: '@@iterator']()'
57+
```
58+
59+
This is a transpiler issue related to the es6 "for of" loop. It is
60+
believed to be limited to the **react-native android JS engine**.
61+
62+
This may be a babel transpiler issue (possibly due to a stale babel
63+
version), or an issue with with react-native android's JS engine.
64+
The problem was temporarily avoided by employing old style es5 "for
65+
loop" constructs (till further research is conducted).
66+
67+
68+
69+
70+
71+
72+
73+
<!-- *** RELEASE *************************************************************** -->
74+
75+
## v0.1.0 - Initial Release *(March 6, 2018)*
76+
[GitHub Content](https://github.com/KevinAst/feature-redux/tree/v0.1.0)
77+
&bull;
78+
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/v0.1.0)
79+
80+
**This is where it all began ...**
81+

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "feature-redux",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"description": "feature-u redux integration",
55
"main": "lib/index.js",
66
"browser": {

src/reducerAspect.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,15 @@ export function accumAppReducer(aspectName, activeFeatures, allowNoReducers$=nul
290290
// }
291291
// }
292292
const shapedGenesis = {};
293-
for (const feature of activeFeatures) {
293+
294+
// using old style es5 "for loop" in lieu of es6 "for of"
295+
// ... issue in react-native android JS engine:
296+
// ERROR: missing Symbol.iterator: '@@iterator'
297+
// ... may be related to android JS engine -or- stale babel transpiler
298+
// ... for now, using es5 "for loop" is path of least resistance
299+
//for (const feature of activeFeatures) {
300+
for (let i=0; i<activeFeatures.length; i++) {
301+
const feature = activeFeatures[i];
294302

295303
// only interpret features that define our aspect
296304
if (feature[aspectName]) {

0 commit comments

Comments
 (0)