Merge pull request #106 from KevinnZou/bugfix/websetting

Bugfix/websetting

Author: KevinnZou

README.md

@@ -399,12 +399,15 @@ Developers can configure custom settings in the shared code in the following way
 val webViewState = rememberWebViewStateWithHTMLData(
     data = html
 )
-webViewState.webSettings.apply {
-    isJavaScriptEnabled = true
-    androidWebSettings.apply {
+DisposableEffect(Unit) {
+    webViewState.webSettings.apply {
+      isJavaScriptEnabled = true
+      androidWebSettings.apply {
         isAlgorithmicDarkeningAllowed = true
         safeBrowsingEnabled = true
+      }
     }
+    onDispose { }
 }
 ```
 

docs/setting.md

@@ -73,11 +73,14 @@ Developers can configure custom settings in the shared code in the following way
 val webViewState = rememberWebViewStateWithHTMLData(
     data = html
 )
-webViewState.webSettings.apply {
-    isJavaScriptEnabled = true
-    androidWebSettings.apply {
-        isAlgorithmicDarkeningAllowed = true
-        safeBrowsingEnabled = true
+DisposableEffect(Unit) {
+    webViewState.webSettings.apply {
+        isJavaScriptEnabled = true
+        androidWebSettings.apply {
+            isAlgorithmicDarkeningAllowed = true
+            safeBrowsingEnabled = true
+        }
     }
+    onDispose { }
 }
 ```

sample/shared/src/commonMain/kotlin/com/kevinnzou/sample/BasicWebViewSample.kt

@@ -19,6 +19,7 @@ import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.ArrowBack
 import androidx.compose.material.icons.filled.Close
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.DisposableEffect
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -53,12 +54,14 @@ import kotlinx.coroutines.flow.filter
 internal fun BasicWebViewSample() {
     val initialUrl = "https://github.com/KevinnZou/compose-webview-multiplatform"
     val state = rememberWebViewState(url = initialUrl)
-    LaunchedEffect(Unit) {
+    DisposableEffect(Unit) {
         state.webSettings.apply {
             logSeverity = KLogSeverity.Debug
             customUserAgentString =
                 "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1) AppleWebKit/625.20 (KHTML, like Gecko) Version/14.3.43 Safari/625.20"
         }
+
+        onDispose { }
     }
     val navigator = rememberWebViewNavigator()
     var textFieldValue by remember(state.lastLoadedUrl) {

webview/src/desktopMain/kotlin/com/multiplatform/webview/web/WebView.desktop.kt

@@ -138,13 +138,13 @@ fun DesktopWebView(
     browser?.let {
         SwingPanel(
             factory = {
+                onCreated()
                 state.webView = desktopWebView
                 webViewJsBridge?.webView = desktopWebView
                 browser.apply {
                     addDisplayHandler(state)
                     addLoadListener(state, navigator)
                 }
-                onCreated()
                 browser.uiComponent
             },
             modifier = modifier,

webview/src/iosMain/kotlin/com/multiplatform/webview/web/WebView.ios.kt

@@ -79,6 +79,7 @@ fun IOSWebView(
                 frame = CGRectZero.readValue(),
                 configuration = config,
             ).apply {
+                onCreated()
                 allowsBackForwardNavigationGestures = captureBackPresses
                 customUserAgent = state.webSettings.customUserAgentString
                 this.addProgressObservers(
@@ -101,7 +102,6 @@ fun IOSWebView(
                         showsVerticalScrollIndicator = it.showVerticalScrollIndicator
                     }
                 }
-                onCreated()
             }.also {
                 val iosWebView = IOSWebView(it, scope, webViewJsBridge)
                 state.webView = iosWebView