Merge pull request #69 from Keyfactor/release-3.1

Merge 3.1.10 to main

Author: spbsoluble

AzureKeyVault/AzureKeyVault.csproj

@@ -29,7 +29,7 @@
 		<PackageReference Include="BouncyCastle.NetCore" Version="2.2.1" />
 		<PackageReference Include="Keyfactor.Logging" Version="1.1.2" />
 		<PackageReference Include="Keyfactor.Orchestrators.Common" Version="3.2.0" />
-		<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="0.7.0" />
+		<PackageReference Include="Keyfactor.Orchestrators.IOrchestratorJobExtensions" Version="1.0.0" />
 		<PackageReference Include="Keyfactor.Platform.IPAMProvider" Version="1.0.0" />
 		<PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="6.0.0" />
 		<PackageReference Include="Microsoft.Identity.Client" Version="4.68.0" />

AzureKeyVault/Jobs/Management.cs

@@ -17,6 +17,7 @@
 using Keyfactor.Orchestrators.Extensions.Interfaces;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using System.Security.AccessControl;
 
 namespace Keyfactor.Extensions.Orchestrator.AzureKeyVault
 {
@@ -35,23 +36,21 @@ public JobResult ProcessJob(ManagementJobConfiguration config)
 
             InitializeStore(config);
 
+            logger.LogTrace($"raw entry parameters from command: {JsonConvert.SerializeObject(config.JobProperties)}");
+
             JobResult complete = new JobResult()
             {
                 Result = OrchestratorJobStatusJobResult.Failure,
                 FailureMessage = "Invalid Management Operation"
             };
-            object tagsObj;
-            object preserveTagsObj;
+
             string tagsJSON;
             bool preserveTags;
 
-            config.JobProperties.TryGetValue("CertificateTags", out tagsObj);
-
-            config.JobProperties.TryGetValue(EntryParameters.PRESERVE_TAGS, out preserveTagsObj);
-
-            preserveTags = (bool)preserveTagsObj;
+            logger.LogTrace("parsing entry parameters.. ");
 
-            tagsJSON = tagsObj as string;
+            tagsJSON = config.JobProperties[EntryParameters.TAGS] as string ?? string.Empty;
+            preserveTags = config.JobProperties[EntryParameters.PRESERVE_TAGS] as bool? ?? false;
 
             switch (config.OperationType)
             {