Skip to content

Commit 037e9d9

Browse files
authored
Merge pull request #18 from Keyfactor/localdev
fix(makefile): Bug naming convention in deploy-local target
2 parents 8d16335 + a0812c5 commit 037e9d9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
## Features
44
* feat(signer): Signer recognizes `metadata.command-issuer.keyfactor.com/<metadata-field-name>: <metadata-value>` annotations on the CertificateRequest resource and uses them to populate certificate metadata in Command.
55
* feat(release): Container build and release now uses GitHub Actions.
6+
7+
## Fixes
68
* fix(helm): CRDs now correspond to correct values for the `command-issuer`.
79
* fix(helm): Signer Helm Chart now includes a `secureMetrics` value to enable/disable sidecar RBAC container for further protection of the `/metrics` endpoint.
810
* fix(signer): Signer now returns CA chain bytes instead of appending to the leaf certificate.

Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ DOCKER_REGISTRY ?= ""
66
DOCKER_IMAGE_NAME ?= ""
77
# Image URL to use all building/pushing image targets
88
IMG ?= ${DOCKER_REGISTRY}/${DOCKER_IMAGE_NAME}:${VERSION}
9-
#IMG ?= command-issuer-dev:latest
109

1110
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
1211
ENVTEST_K8S_VERSION = 1.26.0
@@ -131,8 +130,8 @@ deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in
131130
# Then, install it into the K8s cluster
132131
.PHONY: deploy-local
133132
deploy-local: manifests kustomize ## Build docker image with the manager.
134-
docker build -t ejbca-issuer-dev:latest -f Dockerfile .
135-
cd config/manager && $(KUSTOMIZE) edit set image controller=ejbca-issuer-dev:latest
133+
docker build -t command-issuer-dev:latest -f Dockerfile .
134+
cd config/manager && $(KUSTOMIZE) edit set image controller=command-issuer-dev:latest
136135
$(KUSTOMIZE) build config/default | kubectl apply -f -
137136

138137
.PHONY: undeploy

0 commit comments

Comments
 (0)