Skip to content

Commit dace4df

Browse files
committed
chore: address github copilot feedback
Signed-off-by: Matthew H. Irby <[email protected]>
1 parent ba5fb61 commit dace4df

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

docsource/content.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ Command Issuer is installed using a Helm chart. The chart is available in the [C
112112
--create-namespace
113113
```
114114

115+
> For all possible configuration values for the command-cert-manager-issuer Helm chart, please refer to [this list](./deploy/charts/command-cert-manager-issuer/README.md#configuration)
116+
115117
> The Helm chart installs the Command Issuer CRDs by default. The CRDs can be installed manually with the `make install` target.
116118

117119
# Authentication

e2e/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Modify the fields as needed.
3939

4040
```bash
4141
# enable the script to be executed
42-
chmod +x ./run_test.sh
42+
chmod +x ./run_tests.sh
4343

4444
# load the environment variables
4545
source .env

e2e/run_tests.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,13 @@ install_cert_manager_issuer() {
205205

206206
CHART_PATH="command-issuer/command-cert-manager-issuer"
207207
echo "Using Helm chart from repository for version ${HELM_CHART_VERSION}: $CHART_PATH..."
208-
VERSION_PARAM="--version ${HELM_CHART_VERSION} --devel"
208+
209+
# Only include --devel if HELM_CHART_VERSION is a pre-release (contains -alpha, -beta, -rc, etc.)
210+
if [[ "${HELM_CHART_VERSION}" =~ -alpha|-beta|-rc ]]; then
211+
VERSION_PARAM="--version ${HELM_CHART_VERSION} --devel"
212+
else
213+
VERSION_PARAM="--version ${HELM_CHART_VERSION}"
214+
fi
209215
fi
210216

211217
# Only set the image repository parameter if we are deploying locally
@@ -482,10 +488,10 @@ delete_certificate() {
482488
echo "🗑️ Deleting certificate..."
483489

484490
if cr_exists $CERTIFICATE_CRD_FQTN "$ISSUER_NAMESPACE" "$CR_C_NAME"; then
485-
echo "Deleting Certificate called $CR_CR_NAME in $ISSUER_NAMESPACE"
491+
echo "Deleting Certificate called $CR_C_NAME in $ISSUER_NAMESPACE"
486492
kubectl -n "$ISSUER_NAMESPACE" delete certificate "$CR_C_NAME"
487493
else
488-
echo "⚠️ Certificate $CR_CR_NAME not found in $ISSUER_NAMESPACE"
494+
echo "⚠️ Certificate $CR_C_NAME not found in $ISSUER_NAMESPACE"
489495
fi
490496
}
491497

0 commit comments

Comments
 (0)